On 22.05.2017 12:40, Giuseppe Aruta wrote:
> 1. open Project Properties
> 2. enable Metadata Change checkbox (a "Cancel" button that is enabled
> together with "Apply")
> 3. change the comment
> 4. ups, i erred, i want the old entry back
> 
> As the GUI is defined (by MultiInputDialog) can see two schenarios:
> *) If the "Apply" button is not clicked, it close the diallog with no
> effects on any modification the user can do (see Style dialog). *The old
> good entry is save*.

yes, but un-intuitive as the user would expect an alternative to APPLY 
buttonwise ;)

the Change Style Dialog is actually wrong as well. it allows you to apply a 
style and after that Cancel and Ok have the same function. so it is not exactly 
a good role model to follow here.

i suggest you choose either

OK/Cancel - advantage easy to understand, disadvantage OK saves the new values 
& closes the dialog, no visual confirmation

OK, replaced by Cancel/Apply on changes, back to OK only when changes were 
applied/cancelled - advantage visual confirmation of the changes, disadvantage 
more effort to implement

> but
> **) if the  "Apply" button is clicked before than "Cancel" button, this
> will close dialog but modifications are not restored to original values. *The
> old good entry is gone.*

that's how it usually works

> I am thinking more to an extra button, located close to "Edit project
> metadata", called "Restore metadata form file" that does the job.
> This would work even if the user changes his mind after having clicked
> "Apply" and inadvertently closed the dialog.

ok, that's an idea. but do you really think it is worth the effort? are the SRS 
code and an info comment that difficult to reentry by hand? ;) 

> Extra schenario. The user does 1 to 4 steps, click "Apply" button, closes
> the dialog, *saves project* and "repents at the end of his days".
> Possible solutions
> a) add an extra warning on SaveProject plugin that that project is going to
> be saved
> b) implement undo/redo on TaskPropertiesPlugin
> 

same as above, SRS code and info comment. nothing crucial around here ;).. ede

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Reply via email to