Hi Peppe,

It should be almost repaired. It is still missing a fix to prevent writing the data file for the view while saving the project.

Let me know if there is still something wrong.

Michaël


Le 19/08/2018 à 21:52, Michaël Michaud a écrit :

Hi Peppe,

Thanks a lot for letting me know. I'll try to check that as soon as possible.

Michaël


Le 19/08/2018 à 18:04, Giuseppe Aruta a écrit :
Hi Michael,
I gave a look at the usage of LayerView class and I found a bug on opening project if layerViews are saved into a project file
This is the sequence:

1) I create a project and load (or create) a new layer
2) I create a layerView of selected layer and click to save the project
3) OpenJUMP asks to save the newly created layer (=layerView) as JMP or SHP. 4) I select to create a new layer. The the saving project is finalized and a project file is saved. 5) I try to open the project.the _project is not opened_ and an error message shows the problem is in OpenProjectWizard, possibly on loadLayers(...) method:

j/ava.lang.Exception: Caricando il file progetto 'C:\Users\Beppe\Desktop\2.jmp' fallito con errore:
com.vividsolutions.jump.workbench.model.LayerView.
    at org.openjump.core.ui.plugin.file.open.OpenProjectWizard.open(OpenProjectWizard.java:195)     at org.openjump.core.ui.plugin.file.open.OpenProjectWizard.open(OpenProjectWizard.java:132)     at org.openjump.core.ui.plugin.file.open.OpenProjectWizard.run(OpenProjectWizard.java:127)     at org.openjump.core.ui.plugin.AbstractWizardPlugin.run(AbstractWizardPlugin.java:73)/
/   .........................................../

I opened the project file with a text editor and substitute
any
layer class="com.vividsolutions.jump.workbench.model.LayerView"
with
layer class="com.vividsolutions.jump.workbench.model.Layer"

In this case I can open the project file in openjump with no problem.

------------------------------------------------------------------------------------------
Apart from the bug, I have some observations for possible further development

a) a LayerView is be a simple "view" of a layer: the modification action is syncroniozed: whenever I modified the geometries of a layer, the modification affects also the conresponding LayerView. In this case the "view" could be a parameter to save only into the project file without  the need to create a clone of the layer.

b) II found the LayerView can have a great positive impact on OJ style as users can create multiple views of the same layer with different styles. I explored the possibility to create subviews of a selected layer, according to defined attribute (*). The easy way was to create sub feature collections according to the attribute, create conresponding sub-layers (which are not opened into the view, create conresponding views to load into the view. Of coarse  those subviews are not subviews of the original layer but subviews of sub-layers. The syncronized modification is lost.



(*) This could be extremely useful as OJ lacks of a good point/linestring decoration symbology according to attribute. I am Thinking about vertex symbol rotation, the usage of wkt files, text display next to symbols - what is available in CadPlann symbology plugin available only for basic style


Best regards and thanks for your job

Peppe



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org!http://sdm.link/slashdot


_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Reply via email to