Uhm... a service may be backward compatible and can therefore support different request versions? - just guessing ;)
On Fri, Feb 22, 2019, 10:42 Michaël Michaud, <m.michael.mich...@orange.fr> wrote: > Ede, > > This value is not used. WMSRequest version is initialized from WMService > version. Not sure why version is an attribute of both WMService and > WMSRequest. > > I just was adviced from my IDE. Let me have a deeper look. I subclass > could use the previous default value if it does not use super() in > constructor, but I can't see any reason to encourage it... > > Michaël > > Le 22/02/2019 à 11:08, edgar.sol...@web.de a écrit : > > hey Mike, > > > > can you tell me why you removed the default value for 'version' below? > ..ede > > > > On 22.02.2019 08:35, jump-pilot-svn--- via Jump-pilot-devel wrote: > >> Modified: core/trunk/src/com/vividsolutions/wms/AbstractWMSRequest.java > >> =================================================================== > >> --- core/trunk/src/com/vividsolutions/wms/AbstractWMSRequest.java > 2019-02-21 07:21:47 UTC (rev 6133) > >> +++ core/trunk/src/com/vividsolutions/wms/AbstractWMSRequest.java > 2019-02-22 07:35:16 UTC (rev 6134) > > SNIP > >> @@ -25,12 +21,11 @@ > >> import com.vividsolutions.jump.util.FileUtil; > >> import com.vividsolutions.jump.workbench.Logger; > >> import > com.vividsolutions.jump.workbench.ui.network.ProxySettingsOptionsPanel; > >> -import > com.vividsolutions.jump.workbench.ui.plugin.PersistentBlackboardPlugIn; > >> > >> abstract public class AbstractWMSRequest implements WMSRequest { > >> > >> protected WMService service; > >> - protected String version = WMService.WMS_1_1_1; > >> + protected String version; > >> protected HttpURLConnection con = null; > > > > > > _______________________________________________ > > Jump-pilot-devel mailing list > > Jump-pilot-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > > > > > _______________________________________________ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >
_______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel