Hi,

Slowdown due to FlexibleDateParser seems almost solved.

I reactivated the code parsing Date attributes as dates during data loading. The slowdown observed during saving should be moved to loading, but thanks to Ede's fix, FlexibleDateParser is now much more efficient (exploration to find the right parser is done only once).

Tested with a dataset of 200 000 features

1.15 : most read/write operation last about 2s, but saving a shp from flexiblefeature (where dates are stored as string) lasts 2 minutes

now : read and write operations take about 2s

Also fixed a problem preventing read of files exported from qgis in spatialite format,

and reported a problem with date/timestamp parsing in the sqlite driver (sql datatype returned for timestamp type is ok if the timestamp is stored as integer but it is not recognized if the timestamp is stored as character) 

Michaël




envoyé : 21 août 2020 à 10:58
de : edgar.sol...@web.de
à : Michaud Michael <m.michael.mich...@orange.fr>, OpenJump develop and use <jump-pilot-devel@lists.sourceforge.net>
objet : Re: [JPP-Devel] sqlite database


On 21.08.2020 10:52, Michaud Michael wrote:

Sorry, I think my test base was empty or something like that

hehe, yeah the feeling you get after you spend hours fixing something and wonder why it still does not work that you are are editing the wrong repo/code path, that you were dead sure was the correct one ;)

I'll have more time tonight or tomorrow do re-test and give you more elements if
it still not work.

I'm quite confident it will work. It may just miss better error handling for
"beginners" ;-)

yeah, NPEs should never be exposed to the user!.. cloudy but warm greetings ede

Michaël

>> envoyé : 21 août 2020 à 10:28>> de : edgar.sol...@web.de
>> à : jump-pilot-devel@lists.sourceforge.net
>> objet : Re: [JPP-Devel] sqlite database
>>
>>
>> Nico, maybe Mike can provide you the sqlite file he created to test against?.. ede
>>
>> On 21.08.2020 10:25, Nicolas Ribot wrote:
>>
>>> Hi,
>>>
>>> It was supposed to work.
>>> I will have a look
>>>
>>> Nicolas
>>>
>>> On Thu, 20 Aug 2020 at 20:24, Michaud Michael <m.michael.mich...@orange.fr>
>>> wrote:
>>>
>> >> Hi Jukka, Nicolas>>
>> >> Do you know the state of sqlite in OpenJUMP ? I've tried to load a table
>> >> from a sqlite database for a few hours without success.
>> >>
>> >> I tried with OJ 1.14, 1.15, last snapshot, and I tried to load from a
>> >> database created from a shapefile with spatialite-gui or from a database
>> >> created from QGis as a spatialite or as geopackage. Maybe I omitted
>> >> something obvious, I'm not familiar with sqlite.
>> >>
>> >> For all my tests, I get the same error after I have choosen the table and
>> >> clicked on finish. The error seems related to geometry retrieval or index
>> >> retrieval :
>> >>
>> >> java.lang.NullPointerException
>> >> at
>> >>
>> com.vividsolutions.jump.datastore.spatialite.SpatialiteSQLBuilder.buildSpatialIndexFilter(SpatialiteSQLBuilder.java:157)
>> >> at
>> >>
>> com.vividsolutions.jump.datastore.spatialite.SpatialiteSQLBuilder.buildBoxFilter(SpatialiteSQLBuilder.java:116)
>> >> at
>> >>
>> com.vividsolutions.jump.datastore.spatialite.SpatialiteSQLBuilder.getSQL(SpatialiteSQLBuilder.java:39)
>> >>
>> >> Thanks for the help,
>> >>
>> >> Michaël
>> >> _______________________________________________
>> >> Jump-pilot-devel mailing list
>> >> Jump-pilot-devel@lists.sourceforge.net
>> >> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>> >>
>>
>>> _______________________________________________
>>> Jump-pilot-devel mailing list
>>> Jump-pilot-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>>
>>
>>
>> _______________________________________________
>> Jump-pilot-devel mailing list
>> Jump-pilot-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>
>

_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Reply via email to