On 8/31/2020 12:32, michael michaud wrote:
> Ede, I prefer to document the usage of I18N in Extension in a separate ticket.
ok
> Here are two reasons which drove me to use a hack instead of the I18N class
> (indeed there is a third : I have been too lazy to try to fix the two former
> reasons) :
> - using categoryPrefixOrPath with properties files in the classpath means
> files are in a subdirectory named language/jump (generally possible, but no
> much reason to be constrained like that);
i believe that's the the path prefix possibility was added
> - the only public method you can use to get a key in this case is
> getText(final String categoryPrefix, final String key).
which i deprecated in favour of the newer more formalized getMessage()
> Currently, getMessage(final Object categoryPrefixOrPathOrI18n,
> final String label, final Object... objects) is private. Not sure if we must
> make it public or if we must use I18N instances in extensions instead of
> static methods. A class instance could avoid repeating the
> categoryPrefixOrPathOrI18n parameter again and again).
indeed it would. probably why i kept the full getMessage() private too add a
way not to be forced to use it over and over. can't tell you anymore. long time
ago.
i see that getMessage(final _File path_, final String label, final Object...
objects) is public already ;)
> - indeed, we can create an instance of I18 for a particular extension, but we
> cannot really use it as most methods are static. For example, if I create an
> instance for myExtension, calling getMessage(final String label, final
> Object... objects) will not search keys in myExtension but in main openjump
> properties file
unfortunately we cannot make getMessage() not-static without changing a lot of
code. how about just adding instance version just named get(final String label,
final Object... objects)? should suffice or?
..ede
---
** [bugs:#501] I18N from extension**
**Status:** open
**Milestone:** undecided
**Created:** Mon Aug 31, 2020 10:32 AM UTC by michael michaud
**Last Updated:** Mon Aug 31, 2020 10:32 AM UTC
**Owner:** nobody
Ede, I prefer to document the usage of I18N in Extension in a separate ticket.
Here are two reasons which drove me to use a hack instead of the I18N class
(indeed there is a third : I have been too lazy to try to fix the two former
reasons) :
- using categoryPrefixOrPath with properties files in the classpath means files
are in a subdirectory named language/jump (generally possible, but no much
reason to be constrained like that);
- the only public method you can use to get a key in this case is
getText(final String categoryPrefix, final String key). Currently,
getMessage(final Object categoryPrefixOrPathOrI18n,
final String label, final Object... objects) is private. Not sure if we
must make it public or if we must use I18N instances in extensions instead of
static methods. A class instance could avoid repeating the
categoryPrefixOrPathOrI18n parameter again and again).
- indeed, we can create an instance of I18 for a particular extension, but we
cannot really use it as most methods are static. For example, if I create an
instance for myExtension, calling getMessage(final String label, final
Object... objects) will not search keys in myExtension but in main openjump
properties file
---
Sent from sourceforge.net because jump-pilot-devel@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/jump-pilot/bugs/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/jump-pilot/admin/bugs/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list._______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
