Hi Ede,

Thank you for improvements.

I fixed broken BeanTools. There was several kinds of problems, one of which was that it still pointed to old JTS library.

In you last commits, I also noticed that you changed plugin resources like icon from private to public.

I think that we should not encourage to use a plugin resource from another plugin this way. How will developper know

that the Icon is shared and that changing it will impact another plugin ? If the idea is to not load the same image several

times, why not using a cache (a map) in the IconLoader so that it is clear that it is a shared resource.

Michaël

envoyé : 26 janvier 2022 à 00:22
de : edgar.sol...@web.de
à : OpenJump develop and use <jump-pilot-devel@lists.sourceforge.net>
objet : [JPP-Devel] polished BeanTools a bit


hey Mike,

just wanted to do a minor fixup on BeanTools but ended up doing a little more. hope you like the changes.
https://github.com/openjump-gis/openjump/commit/2c60ff04dd94b1b896a142ac49676e87bb31bd6a
https://github.com/openjump-gis/openjump/commit/f9dc0b716df56250f0eb7262dc4ae143b096945e

while reordering the existing scripts, i was not sure about some and left them in lib/ext/BeanTools/, but probably more may be placed under Examples/. could you please have a look? not sure the numbering is really needed or helpful after sorting out the scripts.

i didn't actually test most of them, just fixed up Refresh. SaveViewAsBean seems broken just now. others might be as well.

regards.. ede




_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Reply via email to