Mike,
see the "fix" here
https://github.com/openjump-gis/cadtools-extension/commit/cb8857f2c053a002c8f084ab25d27edb33975e50
essentially it calls `FeatureDrawingUtil.createAddCommand()` which in turn
checks `geometry.isValid()` if creation of of invalid geometries is configured
forbidden (default).
https://github.com/openjump-gis/openjump/blob/HEAD/src/com/vividsolutions/jump/workbench/ui/cursortool/editing/FeatureDrawingUtil.java#L156
this fails since JTS 1.19 afaics. ..ede
On 28.08.2022 17:38, Michaud Michael wrote:
Ede,
I had a look on the first wkt (bore_01) and a few others and they seem fine to
me.
Did you notice that in the files, the wkt geometry is preceded by two distinct
fields which do not belong to the geometry ?
How did you check their validity ?
Michaël
envoyé : 28 août 2022 à 17:15
de : edgar.sol...@web.de
à : Michaud Michael <m.michael.mich...@orange.fr>, OpenJump develop and use
<jump-pilot-devel@lists.sourceforge.net>
objet : Re: invalid vertex symbols
thx Mike,
i'll cc the list.
very well, i'll put the fixup of the wkt geometries from
https://github.com/openjump-gis/vertex-symbols/tree/main/src/main/resources/VertexImages
into more capable hands then mine. if s.b. sends me a zip with fixed wkts, i
will gladly commit those. Pepe, Jukka, Mike? any takers?
i'll fix CadTools extension to not throw an NPE but the proper error message as
you suggested, which will of course be half of the fix only (at least for now)
then.
..sunny regards ede
On 28.08.2022 16:59, Michaud Michael wrote:
Ede,
My general advice would be to not include invalid geometries in the distro and
to not authorize creating invalid geometries, even for symbols.
I can't think of a specific process that will break with invalid symbols, but
most often, problems arise, sooner or later (ex. if one want to transform the
symbol or to compute intersections with other objects for advanced cartographic
processing...).
Making invalid geometries valid should be straightforward with OpenJUMP. There
is now two algorithm for that. It may miss a way to process many files in one
step though.
Michaël
>> envoyé : 28 août 2022 à 13:53>> de : Edgar Soldin <ed...@soldin.de>
>> à : Michaël Michaud <m.michael.mich...@orange.fr>
>> objet : invalid vertex symbols
>>
>>
>> hey Mike,
>>
>> could you please answer the below? ..thanks ede
>>
>>
>> -------- Forwarded Message --------
>> Subject: Re: [openjump-gis/openjump] CADTools - Drawing Blocks throws NPEs
(Issue #56)
>> Date: Thu, 25 Aug 2022 20:40:24 +0200
>> From: edgar.sol...@web.de
>> To: jump devel <jump-pilot-devel@lists.sourceforge.net>, Michael Michaud
<m.michael.mich...@orange.fr>
>>
>> wrt. below. alternatively we might add a config setting (default: off) that
enables validity checking when adding CAD-Symbols.
>>
>> ..ede
>>
>> On 25.08.2022 15:07, edgar.sol...@web.de wrote:
>>
>>> hey Mike,
>>>
>>> before i go ahead i'd like you to consult me quickly. CADTools drawing
certain VertexSymbols (e.g. bore_01.wkt) currently fails because the described
geometries fail the JTS geometry check `geometry.isValid()` .
>>> my fix would be to ignore that, as symbols do not need to be valid, but
before i fix the drawing call (29 times) in cadtools-extension you may convince me that
fixing the symbols would be the way to go instead.
>>>
>>> what's your verdict.. thanks! ede
>>>
>>>
>>> On 25.08.2022 08:03, ma15569 wrote:
>>>
>> >> I Ede,>> this is a description of the bug with java version "1.8.0_341"
with *CadTools*
>> >>
>> >> a) select the first icon to the left (Draw a block), select block bore_01
>> >> Everything is fine and the block is drawn with no errors
>> >>
>> >> b) select the second icon to the left (Draw an oriented block)
>> >>
>> >> * move the cursor on the workbench: the shade of the block appears
following the cursor, no error
>> >> * one click and move the cursor: the shade stays on the click
coorsinates rotating according the position of the cursor, no error
>> >> * Dragging the cursor with second click: angle of rotation comes out on
the status bar, rotates, no error
>> >> * Second click )which should draw the rotated block), *the error pops
up*
>> >>
>> >> _```
>> >> java.lang.NullPointerException
>> >> at
com.vividsolutions.jump.workbench.plugin.AbstractPlugIn.execute(AbstractPlugIn.java:376)
>> >> at
com.vividsolutions.jump.workbench.ui.cursortool.AbstractCursorTool.execute(AbstractCursorTool.java:640)
>> >> at
org.openjump.advancedtools.block.DrawOrientedBlockTool.gestureFinished(DrawOrientedBlockTool.java:121)
>> >> at
com.vividsolutions.jump.workbench.ui.cursortool.AbstractCursorTool.fireGestureFinished(AbstractCursorTool.java:621)
>> >> at
org.openjump.core.ui.plugin.edittoolbox.cursortools.ConstrainedMultiClickTool.finishGesture(ConstrainedMultiClickTool.java:280)
>> >> at
org.openjump.core.ui.plugin.edittoolbox.cursortools.ConstrainedMultiClickTool.mouseReleased(ConstrainedMultiClickTool.java:155)
>> >> at
com.vividsolutions.jump.workbench.ui.cursortool.DelegatingTool.mouseReleased(DelegatingTool.java:105)
>> >> ...
>> >>
>> >> |With the previous java version 1.8.0_311 both a) and b) were generating
errors With OpenJUMP 1.16 no error were generating (I did this test just in case to have an
history if there wers some changes) I still think that the bug in CadTools and the one in
VertexImagesas are related as they share some code on how to read WKT symbols, **rotate**
and transform into geometries. I will not open another issue, maybe solving CadTools solves
also VertexImage Bets regards |
>> >>
>> >> —
>> >> Reply to this email directly, view it on GitHub
<https://github.com/openjump-gis/openjump/issues/56#issuecomment-1226813755>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACMDSQNZMXJATWPZ2VA3DLDV24EB3ANCNFSM567OC2XQ>.
>> >> You are receiving this because you commented.Message ID:
<openjump-gis/openjump/issues/56/1226813...@github.com>
>> >>
>>
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
