Thanks Thomas for your work ! One feedback I can give now is that Send2Trash will likely need to be package for conda-forge; If you are looking to get involved in the Python/Jupyter community, this should be a good task to get started !
Cheers ! -- Matthias On Fri, Oct 20, 2017 at 3:02 AM, Thomas Kluyver <[email protected]> wrote: > A change has just landed in master to send deleted notebooks & files to the > platform's native 'trash' mechanism. This could be a valuable safeguard > against accidentally deleting work, but it could also be a source of bugs. > In particular, Linux, MacOS and Windows each have their own trash systems > which work in different ways. We are using the Send2Trash Python package to > abstract over those. > > If you're interested and willing to risk some bugs, please pull master from > the notebook repo and try it out. If you find problems with deleting files, > please file issues on jupyter/notebook as normal. > > https://github.com/jupyter/notebook > > Notes: > - If you want to go back to 'I really mean it' deletion, set > *FileContentsManager.delete_to_trash = False* in your config. > - There is no UI in Jupyter for recovering deleted files; use your desktop > file manager to do this. I don't know of Python wrappers to let us inspect > and recover files from trash across different platforms, but if someone > wants to write a platform-specific extension, go for it. > - The deletion dialog still tells you that deletion is permanent - partly > because it's not easy to recover if it's on a server, partly because it > depends on your config and on the contents manager. > > The merged PR is here: > https://github.com/jupyter/notebook/pull/1968 > > -- > You received this message because you are subscribed to the Google Groups > "Project Jupyter" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jupyter/CAOvn4qh4sp1aUmjiMJJmM-QdJ1p7eFpfOnuLKMdLWfXFW7tnFA%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Project Jupyter" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jupyter/CANJQusWo7pHr4L_Rupkb%3DkGHpgk0nukRQsd60hdQiwOe_nkETQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
