Hi Matthias, I would be glad to make a PR and yes i have also tried it on the master branch. I'll check the guidelines and get the PR up.
Thanks, Aman On Saturday, December 9, 2017 at 8:15:46 PM UTC+5:30, Matthias Bussonnier wrote: > > Hi Aman, > > Thanks for the report, I can reproduce partially what you are describing > but only on a width of a few pixels. Have you tried on the master branch ? > As for your question, yes we usually[1] do all changes via pull requests, > regardless of the size, whether it's a typo, or an extra feature. > If you know how to fix this, and are familar with git, then a pull > request is welcome. If you are not familiar with git or the process, we'll > be happy to guide you through it. > If you know the fix but are not interested to make a PR/no time/... etc. > You are welcome to communicate the fix to us in any way that you feel > appropriate, and we'll do the PR for you. It may take more time though. > > Thanks, > -- > Matthias > > [1] the rare other cases when no PR is done are 1) security fixes – we > discuss the security fixes in a private repo (in a PR) and once agreed it > is pushed directly to the official repo. 2) minor typos and edit at release > time. > > On 9 December 2017 at 15:22, Aman Bansal <[email protected] > <javascript:>> wrote: > >> I found there was a hover error in home page in which whenever i hover on >>> the *"New"* button by first going through the *"Upload" *button the >>> *"Upload"* remains highlighted until i have traveled half of the *"New"* >>> button as seen in the below image which i have also fixed by making changes >>> in the corresponding CSS file so for that small change should i submit a >>> PR. Note this problem is not there when i dierctly go to the *"New"* >>> button. I don't know whether to submit for such a small change as I am new >>> to this project. Waiting for reply. >> >> >> >> >> >> <https://lh3.googleusercontent.com/-9he8cBi5ET8/Wivw2O57D0I/AAAAAAAAAWw/iC0Ltg49jeUv7_6EgOK7jJwad7mj9WyyQCLcBGAs/s1600/bug1.png> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Project Jupyter" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To post to this group, send email to [email protected] >> <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jupyter/12ca1f7b-1b34-4561-b29b-9b94ae817584%40googlegroups.com >> >> <https://groups.google.com/d/msgid/jupyter/12ca1f7b-1b34-4561-b29b-9b94ae817584%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Project Jupyter" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jupyter/7dab0b07-b87d-4be5-be3b-1705ef48155d%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
