Thanks for pinging here. I also added a note on the PR. Jason
On Thu, Mar 29, 2018 at 10:48 AM David Little <david.frank.lit...@gmail.com> wrote: > Hi there, I've just been looking into JupyterLab and it looks great! > Amazing work!! > > I'm interested in contributing to the project in a small way: making it > possible to use the Option Key (on a mac keyboard) as the Meta Key in the > terminal package. I opened an issue > <https://github.com/jupyterlab/jupyterlab/issues/4236> about this a few > days ago. Looks to me like it should be pretty simple to implement, as the > underlying library for the terminal (xterm.js) has the ability to set this > option. > > I think I understand how to change the terminal package so that there is a > way for the user to set this option: it looks like it would involve > creating a new method in terminal package to change this option for > `this._term`, and then, following the example of creating increase-font > commands, creating a command for calling this method within the > terminal-extension package. > > Just wanted to check here, based on the description in the community > guidelines, to see if a pull request with this change would be of interest > before I go and try to implement it. > > -- > You received this message because you are subscribed to the Google Groups > "Project Jupyter" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to jupyter+unsubscr...@googlegroups.com. > To post to this group, send email to jupyter@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jupyter/10d14769-07fa-4a7c-a57d-898711c1770c%40googlegroups.com > <https://groups.google.com/d/msgid/jupyter/10d14769-07fa-4a7c-a57d-898711c1770c%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Project Jupyter" group. To unsubscribe from this group and stop receiving emails from it, send an email to jupyter+unsubscr...@googlegroups.com. To post to this group, send email to jupyter@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jupyter/CAPDWZHybE4KufeyQ-GfGdDwbotvAxCmwXgpUfB9vqQNiDwyTAQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
