Hi Jevon,

Tested on Windows and Linux and no problem concerning JUnit tests. I will try 
to test a bit more on Windows tomorrow.

Concerning what you did on documentation there are some points on which I think 
we misanderstood each other:

1) The point I wanted to fix was using JUnit setUp to perform test 
initialization instead of constructor (which doesn't work in fact)
2) Why did you remove the delegation sample (using WebTester directly instead 
of WebTestCase)? Until you manage to merge both I suppose we should keep the 
two samples for people that simply can't inherit from WebTestCase.

I will do the modifications, please review and give me your comments.

Best regards,

Julien




________________________________
De : Jevon Wright <[EMAIL PROTECTED]>
À : JWebUnit Development mail list <[email protected]>
Envoyé le : Lundi, 8 Décembre 2008, 3h29mn 06s
Objet : Re: [JWebUnit-development] Re : Re : New release

Hi Julien,

I had some weirdness with Maven before - your changes broke some of my test 
cases, but only during site-deploy. Yet after I fixed these issues, Maven was 
still failing, even after mvn clean and deleting the deployed site -- but only 
for mvn site:stage. And it was failing on a source code line that didn't exist, 
so obviously it was testing it against an older cached version. Please let me 
know if the test cases are now failing for you too.

I've cleaned up the quickstart a little bit, in particular the introduction. 
What do you think?

Jevon


On Mon, Dec 8, 2008 at 12:45 PM, Jevon Wright <[EMAIL PROTECTED]> wrote:

Hi Julien,

That's great, thanks for working out those problems!

I don't know how to resolve the Javadoc problem of no documentation for 
WebTestCase -- I don't know of any way in Maven to specify additional sources 
for Java code. If we remove the WebTestCase generator then we will not need to 
solve this problem, since WebTestCase will be static. 

(If you don't want to release 2.1 just yet without WebTestCase docs then we 
could release an RC. But technically it's never had Javadocs AFAIK.)

I've added issue 2404789 for the quickstart.html documentation and I'll get 
onto that later today hopefully.

Cheers!
Jevon



On Mon, Dec 8, 2008 at 11:51 AM, Julien HENRY <[EMAIL PROTECTED]> wrote:

Jevon,

I've fixed the setTimeout issue. It seems there was 2 causes:
1) timout on HtmlUnit is milliseconds and not seconds
2) The wait on the servlet was not working on my computer (nanoTime seems 
broken, reverted to currentTimeMillis.


I've also fixed broken links on the site.

What I know want to do is adress Javadoc issue (perhaps using a SNAPSHOT 
version of Javadoc plugin).

Also, all the site documentation is wrong concerning usage of constructor 
initialization versus setUp(). All code samples in quickstart.html should be 
updated. I remember havong users complaining about this point.

I plan to do the release this week as soon as Javadoc and site doc is ok.

Best regards,

Julien



________________________________
De : Jevon Wright <[EMAIL PROTECTED]>
À : JWebUnit Development mail list <[email protected]>
Envoyé le : Dimanche, 7 Décembre 2008, 5h57mn 50s
Objet : Re: [JWebUnit-development] Re : New release


I am working on Windows XP. Have you had any luck in working out the problem? I 
wish I could reproduce this locally but the tests have always passed, both in 
mvn test and mvn site. I will try site-deploy tomorrow.

Cheers
Jevon


On Fri, Dec 5, 2008 at 9:21 AM, Julien HENRY <[EMAIL PROTECTED]> wrote:

In fact I get only one error when I run mvn site site-deploy

Note that JUnit tests are run several times (one for real, one for site reports)


-------------------------------------------------------------------------------
Test set: net.sourceforge.jwebunit.htmlunit..JWebUnitTest
-------------------------------------------------------------------------------
Tests run: 306, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.449 sec <<< 
FAILURE!
testTimeout(net.sourceforge.jwebunit.tests.ResponseServletTest)  Time elapsed: 
0.021 sec  <<< FAILURE!

junit.framework.AssertionFailedError: Text found in response when not expected: 
[hello, world!]
    at junit.framework.Assert.fail(Assert.java:47)
    at 
net.sourceforge.jwebunit.junit.WebTester.assertTextNotPresent(WebTester.java:510)
    at 
net.sourceforge.jwebunit.junit.WebTestCase..assertTextNotPresent(WebTestCase.java:431)
    at 
net.sourceforge.jwebunit.tests.ResponseServletTest.testTimeout(ResponseServletTest.java:92)




________________________________
 De : Julien HENRY <[EMAIL PROTECTED]>

À : JWebUnit Development mail list <[email protected]>
Envoyé le : Jeudi, 4 Décembre 2008, 21h06mn 00s
Objet : [JWebUnit-development] Re :  New release



Works fine on my Linux box.

Which OS are you working on?




________________________________
De : Jevon Wright <[EMAIL PROTECTED]>
À : JWebUnit Development mail list <[email protected]>
Envoyé le : Jeudi, 4 Décembre 2008, 0h18mn 55s
Objet : Re: [JWebUnit-development] New release

That is weird. My tests run fine, I think with the Jetty server built into 
JWebUnit.

If your testing machine is very slow, the setUp() method in that test case sets 
the timeout to 2 seconds - perhaps it needs to be extended (the timeout limit 
can only be setup before the web client is initialised).

Jevon


On Wed, Dec 3, 2008 at 9:42 PM, Julien HENRY <[EMAIL PROTECTED]> wrote:

I've some test failures.

Will try to investigate this evening.

-------------------------------------------------------------------------------
Test set: net.sourceforge.jwebunit.htmlunit.JWebUnitTest
-------------------------------------------------------------------------------
Tests run: 306, Failures: 1, Errors: 2, Skipped: 0, Time elapsed: 34.653 sec 
<<< FAILURE!
testDefault(net.sourceforge..jwebunit.tests.ResponseServletTest)  Time elapsed: 
0.063 sec  <<< ERROR!
java.lang.RuntimeException: java.net.SocketTimeoutException: Read timed out
    at 
net.sourceforge.jwebunit.htmlunit.HtmlUnitTestingEngineImpl..gotoPage(HtmlUnitTestingEngineImpl.java:220)
    at 
net.sourceforge.jwebunit.htmlunit.HtmlUnitTestingEngineImpl.beginAt(HtmlUnitTestingEngineImpl.java:173)
    at net.sourceforge.jwebunit.junit.WebTester.beginAt(WebTester.java:192)
    at net.sourceforge.jwebunit.junit.WebTestCase.beginAt(WebTestCase..java:160)
    at 
net.sourceforge.jwebunit.tests.ResponseServletTest..testDefault(ResponseServletTest.java:36)
Caused by: java.net.SocketTimeoutException: Read timed out
    at java.net.SocketInputStream.socketRead0(Native Method)
    at java.net.SocketInputStream.read(SocketInputStream..java:129)
    at java..io.BufferedInputStream.fill(BufferedInputStream.java:218)
    at java.io.BufferedInputStream.read(BufferedInputStream.java:237)
    at 
org.apache.commons.httpclient.HttpParser..readRawLine(HttpParser..java:78)
    at org.apache.commons.httpclient.HttpParser.readLine(HttpParser.java:106)
    at 
org..apache.commons.httpclient.HttpConnection.readLine(HttpConnection.java:1116)
    at 
org.apache.commons.httpclient.MultiThreadedHttpConnectionManager$HttpConnectionAdapter.readLine(MultiThreadedHttpConnectionManager.java:1413)
    at 
org.apache.commons.httpclient.HttpMethodBase.readStatusLine(HttpMethodBase.java:1973)
    at 
org.apache.commons.httpclient.HttpMethodBase.readResponse(HttpMethodBase.java:1735)
    at 
org.apache.commons.httpclient.HttpMethodBase.execute(HttpMethodBase.java:1098)
    at 
org.apache.commons.httpclient.HttpMethodDirector.executeWithRetry(HttpMethodDirector.java:398)
    at 
org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:171)
    at 
org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:397)
    at 
org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:346)
    at 
com.gargoylesoftware.htmlunit.HttpWebConnection.getResponse(HttpWebConnection.java:97)
    at 
com.gargoylesoftware.htmlunit.WebClient.loadWebResponseFromWebConnection(WebClient.java:1477)
    at 
com.gargoylesoftware.htmlunit.WebClient.loadWebResponse(WebClient.java:1435)
    at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:327)
    at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:388)
    at 
net.sourceforge.jwebunit.htmlunit.HtmlUnitTestingEngineImpl.gotoPage(HtmlUnitTestingEngineImpl.java:210)
    ... 37 more

testResponse200(net.sourceforge.jwebunit.tests..ResponseServletTest)  Time 
elapsed: 0.015 sec  <<< ERROR!
java.lang.RuntimeException: java.net.SocketTimeoutException: Read timed out
    at 
net.sourceforge..jwebunit.htmlunit.HtmlUnitTestingEngineImpl.gotoPage(HtmlUnitTestingEngineImpl.java:220)
    at 
net.sourceforge.jwebunit.htmlunit.HtmlUnitTestingEngineImpl.beginAt(HtmlUnitTestingEngineImpl.java:173)
    at net.sourceforge.jwebunit.junit.WebTester.beginAt(WebTester.java:192)
    at net.sourceforge.jwebunit.junit.WebTestCase.beginAt(WebTestCase.java:160)
    at 
net.sourceforge.jwebunit.tests.ResponseServletTest.testResponse200(ResponseServletTest.java:48)
Caused by: java.net.SocketTimeoutException: Read timed out
    at java.net.SocketInputStream.socketRead0(Native Method)
    at java.net.SocketInputStream.read(SocketInputStream.java:129)
    at java.io.BufferedInputStream.fill(BufferedInputStream.java:218)
    at java.io.BufferedInputStream.read(BufferedInputStream.java:237)
    at org.apache.commons.httpclient.HttpParser.readRawLine(HttpParser.java:78)
    at org.apache.commons.httpclient.HttpParser.readLine(HttpParser.java:106)
    at 
org.apache.commons.httpclient.HttpConnection.readLine(HttpConnection.java:1116)
    at 
org.apache.commons..httpclient.MultiThreadedHttpConnectionManager$HttpConnectionAdapter.readLine(MultiThreadedHttpConnectionManager.java:1413)
    at 
org..apache.commons.httpclient.HttpMethodBase.readStatusLine(HttpMethodBase.java:1973)
    at 
org.apache.commons.httpclient.HttpMethodBase.readResponse(HttpMethodBase.java:1735)
    at 
org.apache.commons.httpclient.HttpMethodBase.execute(HttpMethodBase.java:1098)
    at 
org.apache.commons..httpclient.HttpMethodDirector.executeWithRetry(HttpMethodDirector.java:398)
    at 
org.apache..commons.httpclient..HttpMethodDirector.executeMethod(HttpMethodDirector.java:171)
    at 
org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:397)
    at 
org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:346)
    at 
com.gargoylesoftware.htmlunit.HttpWebConnection..getResponse(HttpWebConnection.java:97)
    at 
com.gargoylesoftware..htmlunit.WebClient.loadWebResponseFromWebConnection(WebClient.java:1477)
    at 
com.gargoylesoftware.htmlunit.WebClient.loadWebResponse(WebClient.java:1435)
    at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:327)
    at com..gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:388)
    at 
net.sourceforge.jwebunit.htmlunit.HtmlUnitTestingEngineImpl.gotoPage(HtmlUnitTestingEngineImpl.java:210)
    .... 37 more

testTimeout(net.sourceforge.jwebunit.tests.ResponseServletTest)  Time elapsed: 
0.016 sec  <<< FAILURE!
junit..framework.AssertionFailedError: Text found in response when not 
expected: [hello, world!]
    at junit.framework.Assert.fail(Assert..java:47)
    at 
net.sourceforge.jwebunit.junit.WebTester..assertTextNotPresent(WebTester.java:510)
    at 
net.sourceforge.jwebunit.junit.WebTestCase.assertTextNotPresent(WebTestCase.java:431)
    at 
net.sourceforge.jwebunit.tests.ResponseServletTest.testTimeout(ResponseServletTest.java:92)




________________________________
De : Jevon Wright <[EMAIL PROTECTED]>
À : JWebUnit Development mail list <[email protected]>
Envoyé le : Mercredi, 3 Décembre 2008, 0h28mn 57s
Objet : Re: [JWebUnit-development] Re : Site index.html changes

Hi Julien,

I am ready for a release if you are! After we release I will try to remove the 
WebTestCase generator so we can test out a beta.

Cheers
Jevon


On Mon, Dec 1, 2008 at 9:46 PM, Julien HENRY <[EMAIL PROTECTED]> wrote:

Hi Jevon,

I didn't build the site with your modifications yet but I read the commit log 
and it seems good for me. I will give additional comments before the release 
(tell me when you are ready).

Regards,

Julien




________________________________
De : Jevon Wright <[EMAIL PROTECTED]>
À : JWebUnit Development mail list <[email protected]>
Envoyé le : Lundi, 1 Décembre 2008, 0h17mn 59s
Objet : [JWebUnit-development] Site index.html changes


Hi,

I have modified the home page of the JWebUnit site quite a bit in r774, and 
would appreciate some feedback.

I made a brief introduction the first thing the user reads, and added a simple 
test case example to the home page. (Simpletest for PHP does the same thing.) I 
also added links to the bug trackers and user mailing lists. When issue 2367400 
is resolved it will also include a direct link to the API docs for WebTestCase.

Thoughts?

Jevon


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
JWebUnit-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jwebunit-development




-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
JWebUnit-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jwebunit-development





------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
JWebUnit-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jwebunit-development




------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
JWebUnit-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jwebunit-development


      
------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
JWebUnit-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jwebunit-development

Reply via email to