Patches item #2647451, was opened at 2009-02-27 21:06 Message generated for change (Comment added) made by sl4mmy You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=497984&aid=2647451&group_id=61302
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: Release 2.2 Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: Kent R. Spillner (sl4mmy) Assigned to: Julien HENRY (henryju) Summary: Expose option to toggle exceptions on Javascript errors Initial Comment: Hi, HTMLUnit provides the option to selectively enable and disable throwing exceptions on Javascript errors. Attached is a patch which exposes this behavior via ITestingEngine and its implementations. HtmlUnitTestingEngineImpl delegates to its WebClient as expected, but the SeleniumTestingEngineImpl throws an UnsupportedOperationException. I don't use Selenium, and am unsure what the proper behavior for Selenium should be, but I am certainly willing to refactor this patch as necessary to better accommodate Selenium users. Although this can lead to false positives in tests and festering Javascript problems that aren't caught until late in the development process, it is desirable when testing behavior which isn't dependent on Javascript. We are using this patch on my current project, and greatly appreciate this extra level of control. ---------------------------------------------------------------------- >Comment By: Kent R. Spillner (sl4mmy) Date: 2009-03-02 12:13 Message: Hi, I've attached another patch to this tracker item that includes unit tests for both implementations (HtmlUnit and Selenium). ---------------------------------------------------------------------- Comment By: Kent R. Spillner (sl4mmy) Date: 2009-03-02 12:12 Message: File Added: optional-fail-on-script-error-with-unit-tests.diff ---------------------------------------------------------------------- Comment By: Julien HENRY (henryju) Date: 2009-02-28 06:55 Message: Patch applied. Next time, could you please try to provide also a JUnit test to aviod regression in the future. Thanks ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=497984&aid=2647451&group_id=61302 ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ JWebUnit-development mailing list JWebUnit-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jwebunit-development
