Patches item #2106019, was opened at 2008-09-11 12:02 Message generated for change (Comment added) made by sl4mmy You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=497984&aid=2106019&group_id=61302
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: Release 2.2 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Kent R. Spillner (sl4mmy) Assigned to: Julien HENRY (henryju) Summary: Enable partial matches of image src and alt attributes Initial Comment: Enable partial matches of image src and alt attributes via XPath's contains() function. This is useful when you want to ignore dynamic request parameters in image URLs, particularly JSESSIONID. ---------------------------------------------------------------------- >Comment By: Kent R. Spillner (sl4mmy) Date: 2009-03-02 12:16 Message: Hi, I've updated the patch to improve the second assertion case (src & alt attribute): the src and alt attributes are checked on the same image, otherwise you might get false positives if a different image matched the given partial alt attribute. I also added unit tests for both assert methods. ---------------------------------------------------------------------- Comment By: Kent R. Spillner (sl4mmy) Date: 2009-03-02 12:14 Message: File Added: updated-partial-image-match-with-unit-tests.diff ---------------------------------------------------------------------- Comment By: Julien HENRY (henryju) Date: 2009-02-28 06:59 Message: Patch seems good, but could you please provide one JUnit test for each new method. Thanks ---------------------------------------------------------------------- Comment By: Kent R. Spillner (sl4mmy) Date: 2009-02-27 20:25 Message: Hi, Thanks for the feedback! The original patch emulated the style of WebTester#assertImagePresent, hence the parameters for both imageAlt and imageSrc. I split WebTester#assertImageContains into two methods: WebTester#assertImageSrcContains and WebTester#assertImageAltContains, and updated the patch. ---------------------------------------------------------------------- Comment By: Kent R. Spillner (sl4mmy) Date: 2009-02-27 20:21 Message: File Added: updated-partial-image-match.diff ---------------------------------------------------------------------- Comment By: Jevon Wright (jevonwright) Date: 2008-10-28 06:02 Message: Hi, What is the point of searching both the src and alt attributes? This patch may be too specific. Instead of having a method with a possibly null parameter, you should provide two methods for both use cases. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=497984&aid=2106019&group_id=61302 ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ JWebUnit-development mailing list JWebUnit-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jwebunit-development
