Hi,

Thanks to all the JWebUnit team, and especially to Julien for his
attention to every message.

This is to record the issues I have encountered in upgrading to
version 3.0 from version 2.2.

I have downloaded the source and built locally, but had to setup a
toolchain.xml in my .m2 directory and disable
header checking before mvn install would work.
I would prefer not to rely upon toolchain.xml as I would wish to build
this under Jenkins and do not wish to set a universal toolchain.
Can this not be moved into the pom.xml file?

========

The class WebTestCase has been deprecated with the message 'use JUnit
4' : I have no intention of using JUnit4,
I do not think it is an improvement on JUnit3, there are many who
share my view.
The JUnit3 project is alive and well and is not going away anytime soon.
Please remove deprecation.

=========

HtmlUnitTestingEngineImpl.gotoPage no longer returns the failing status

    public void gotoPage(URL initialURL) throws TestingEngineResponseException {
        try {
            wc.getPage(initialURL);
            win = wc.getCurrentWindow();
            form = null;
        } catch (FailingHttpStatusCodeException ex) {
                // only throw exception if necessary
                if (!ignoreFailingStatusCodes) {
                    throw new TestingEngineResponseException(
                            "unexpected status code ["+ex.getStatusCode()+"]
at URL: ["+initialURL+"]", ex);
                }
        } catch (IOException ex) {
            throw new RuntimeException(ex);
        }
    }

should be

    public void gotoPage(URL initialURL) throws TestingEngineResponseException {
        try {
            wc.getPage(initialURL);
            win = wc.getCurrentWindow();
            form = null;
        } catch (FailingHttpStatusCodeException ex) {
                // only throw exception if necessary
                if (!ignoreFailingStatusCodes) {
                    throw new TestingEngineResponseException(ex.getStatusCode(),
                            "unexpected status code ["+ex.getStatusCode()+"]
at URL: ["+initialURL+"]",  ex);
                }
        } catch (IOException ex) {
            throw new RuntimeException(ex);
        }
    }

========

assertTextPresent no longer returns text inside a noframes tag - fair
enough, my test changed.

========

The following test alternately fails and succeeds when run from Eclipse:

  private void loginAsAdministrator() {
    gotoPage("/Admin/" + dbName + "/Main");
    gotoFrame("admin_top");
    clickButton("login");
    setTextField("field_login", "_administrator_");
    setTextField("field_password", "FIXME");
    checkCheckbox("rememberme");
    submit("action");
  }

I have not figured out what the problem is, but it looks like
clickButton sometimes fails to have any effect.
I think that this is due to a confusion between current page and current Frame.

If I change this to

  private void loginAsAdministrator() {
    gotoPage("/Admin/" + dbName + "/Top");
//    gotoFrame("admin_top");
    clickButton("login");
    setTextField("field_login", "_administrator_");
    setTextField("field_password", "FIXME");
    checkCheckbox("rememberme");
    submit("action");
  }

it works.
In HtmlElement.click() we have the line
        
getPage().getWebClient().setCurrentWindow(getPage().getEnclosingWindow());
which I think may be the problem.

A similar problem occurs when I click the link in the following, within a frame:
  <font face="Arial, Helvetica">
    <a         href="/melatitest/Admin/admintest/tableInfo/Main"
        target="_top"

        id="continue"
    >Done</a>

The current page text does not change, it used to become the text of
the _top window.

I hope that this feedback is useful.
Thanks again for a great project.

yours
Tim Pizey


-- 
Tim Pizey
http://pizey.net/~timp

------------------------------------------------------------------------------
Get a FREE DOWNLOAD! and learn more about uberSVN rich system, 
user administration capabilities and model configuration. Take 
the hassle out of deploying and managing Subversion and the 
tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2
_______________________________________________
JWebUnit-users mailing list
JWebUnit-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jwebunit-users

Reply via email to