Hi Jon
jon * wrote:
> on 1/21/00 7:18 AM, Jonas Maurus <[EMAIL PROTECTED]> wrote:
>
> > Jon approved and uploaded the new patches.
>
> Ok, I started looking at it...pretty good...a few things that i'm going to
> change:
>
> #1. The LocalizationManager should be a turbine service or at least in its
> own package within turbine. I'm thinking there should be a
> org.apache.turbine.localization package. Within there, one could have the
> LocalizationManager. Then, there would also be a
> org.apache.jyve.localization that would have the jyve specific things. The
> localization manager could be made aware to auto-look into the localization
> package to find the stuff.
>
-1 on that (that is, if my vote counts :-) ). Turbine has zero l10n features by
now, so you probably would just create confusion with that, don't you think ?
>
> #2. remove all tabs. i hate tabs.
>
This is company-internal policy :-). We just all use a tab-ident = 5. Sorry,
should have thought about it before I exported the sources.
>
> #3. change LocalizationManager to not have the hard coded reference to jyve.
>
This results from #1, but as I said, I don't think that it's a good idea.
Basically I'm not in favor of exporting anything from Jyve, because currently
there is one LocalizationManager local to Jyve which handles all Jyve-specific
stuff, with Jyve-specific resources. Exporting it to turbine would in fact break
localization in Jyve as a "standalone product". I almost dare to say that it
would be one more unnecessary connection between these two packages.
Now, if you should go for the turbine-package and remove LocalizationManager
from Jyve, it would be quite nice to have a short feature-freeze period with
turbine, simply because as you probably know, too, Turbine does not build at the
moment, moving in another package into the currently unstable source tree is
probably not the best idea and you guys should get rid of the Collection.class
mismatch between 1.1 and 1.2 anyway.
I would really like to discuss these issues over the week-end, because this
would enable me to work on this on sunday or at least early next week.
Hope to hear from you soon,
-Jonas Maurus ([EMAIL PROTECTED])
Project manager
[!] mediaphil digital media, Germany
--
--------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Archives and Other: <http://java.apache.org/main/mail.html>
Problems?: [EMAIL PROTECTED]
