Guilhem Lavaux wrote:
On Friday 18 July 2003 14:00, Dalibor Topic wrote:

Hallo Sebastian,

thanks for the patch. I've looked over it and looks ni good. I have a
question, though, before I can check it in.

You're using a Vector to store request properties. Why not use a map
instead, like GNU Classpath does (see
http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/java/net/URLCon
nection.java?rev=1.17&content-type=text/vnd.viewcvs-markup )?



Ooops, already commited. It looked quite fine and good to me too. But maybe we can transform the use of Vector in Map. About the rest of modification I have just made tell me quite quickly if there is something wrong because I will not be able to apply modifications for 4-5 days.

That's O.K, the patch is fine. I'm just being curious about the reason for picking Vector for implementation.


cheers,
dalibor topic


_______________________________________________ kaffe mailing list [EMAIL PROTECTED] http://kaffe.org/cgi-bin/mailman/listinfo/kaffe

Reply via email to