in kaffe/kaffevm/exception.h line 99:
void throwException(struct Hjava_lang_Throwable*) NONRETURNING; 

and in kaffe/kaffevm/intrp/machine.c line 270:
                default:
                        dprintf("Unknown bytecode %d\n", code[pc]);
                        throwException(NEW_LANG_EXCEPTION(VerifyError));
                        break;
#include "kaffe.def"
                }
        }
 end:
        return;
}

gcc says:
machine.c:273: warning: will never be executed

does it make sense to remove the break?

patch:

--- machine.c   2004-05-11 12:50:19.000000000 +0200
+++ machine.c.new       2004-06-20 20:17:28.101623584 +0200
@@ -270,7 +270,7 @@
                default:
                        dprintf("Unknown bytecode %d\n", code[pc]);
                        throwException(NEW_LANG_EXCEPTION(VerifyError));
-                       break;
+      /* throwException is NONRETURNING, no break needed */
 #include "kaffe.def"
                }
        }

Do I need a changelog entry for this?!

Cheers,

-- 
Arnaud Vandyck

< doogie> asuffield: how do you think dpkg was originally written?  :|
< asuffield> by letting iwj get dangerously near a computer
                -- in #debian-devel

_______________________________________________
kaffe mailing list
[EMAIL PROTECTED]
http://kaffe.org/cgi-bin/mailman/listinfo/kaffe

Reply via email to