[
https://issues.apache.org/jira/browse/KAFKA-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115989#comment-13115989
]
Jun Rao commented on KAFKA-3:
-----------------------------
Overall, the patch looks good. Some minor comments:
1. Does ZookeeperConsumerConnector.consume need a default decoder? The caller
always passes in a decoder.
2. Shouldn't ConsumerShell use StringDecoder?
3. Consumer.java doesn't need to import kafka.serializer.DefaultDecoder.
4. It seems you don't need the default decoder in
ZookeeperConsumerConnector.createMessageStreams, since the default decoder is
already defined in the trait.
> Consumer needs a pluggable decoder
> ----------------------------------
>
> Key: KAFKA-3
> URL: https://issues.apache.org/jira/browse/KAFKA-3
> Project: Kafka
> Issue Type: Improvement
> Attachments: KAFKA-3_v1.patch, KAFKA-3_v2.patch
>
>
> Kafka producer allows a user to plug in an encoder (from type T to Message).
> We need to do the same thing on the consumer side, by allowing a user to plug
> in a decoder (from Message to type T).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
