On Oct 12, 2011, at 8:41 AM, Neha Narkhede wrote: > Alan, > >> I think we need to pass Rat for all files. > > Rat is known to give false positives as well. I think we need some > more clear input on exactly which files can be excluded. Without that, > it is hard to make a call on whether the > rat test passed or not. Uploaded the rat output on RC2 here - > http://people.apache.org/~nehanarkhede/kafka-0.7.0-incubating-candidate-2/kafka-0.7.0-RC2.rat
I know that there are some files that definitely need to be "stamped". As I mentioned before you'd be surprised at what needs to be stamped. What might be a good thing to do is to review every complaint from RAT and either stamp it or find an example in another project where they don't stamp it and add that file to the excludes. As a mentor I will still need to review all excludes. >> What will be the maven coordinate for this project? > > Does org.apache.kafka sound OK ? Up to you guys but that seems ok to me. >> Did you guys decide on the location for the KEYS file? I see it in a number >> of places. > > Yes. It is checked in as part of kafka/trunk, and that is mentioned in > the RC email I sent. It's also in kafka. There was some discussion on where to put it but I'm not sure there was a conclusion. Regards, Alan > > Thanks, > Neha > > On Wed, Oct 12, 2011 at 7:50 AM, Alan D. Cabrera <[email protected]> wrote: >> I have some very minor questions/points to discuss before we release: >> >> I think we need to pass Rat for all files. >> What will be the maven coordinate for this project? >> Did you guys decide on the location for the KEYS file? I see it in a number >> of places. >> >> >> Regards, >> Alan >> >>
