[
https://issues.apache.org/jira/browse/KAFKA-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140895#comment-13140895
]
Jay Kreps commented on KAFKA-176:
---------------------------------
tryCleanupZookeeper looks cut-and-pasted from place to place. It shows up in
ConsoleConsumer.scala, ReplayLogProducer.scala, and ConsumerPerformance.scala.
We should not do that. Can we make some kind of utility function for that?
Also there is a PerfConfig class, which is a great idea as a way to normalize
some of the config options we are using between all the tools. But it looks
like the class is just duplicated between the tools. Can this be shared?
I would like to cleanup the scripts used to run these things so that we get rid
of all the silly ancient ones (*simple-perf-test.sh and *shell.sh), but I think
I will open a seperate ticket for that since it is unrelated to your changes.
> Fix existing perf tools
> -----------------------
>
> Key: KAFKA-176
> URL: https://issues.apache.org/jira/browse/KAFKA-176
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Neha Narkhede
> Assignee: Neha Narkhede
> Fix For: 0.8
>
> Attachments: kafka-176.patch
>
>
> The existing perf tools - ProducerPerformance.scala,
> ConsumerPerformance.scala and SimpleConsumerPerformance.scala are slightly
> buggy. It will be good to -
> 1. move them to a perf directory from the existing kafka/tools location
> 2. fix the bugs, so that they measure throughput correctly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
