[ 
https://issues.apache.org/jira/browse/KAFKA-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Stein updated KAFKA-193:
----------------------------

    Attachment: kafka-193.patch

new trait in utils/Logging.scala

scoured trunk and re-factored to use trait

handling the incremental updates for patches that go to trunk before this patch 
can maybe just be more patches on this ticket.  after this patch goes to trunk 
it would be great that any new patches start to use the trait.  
                
> use by name parameter helper for logging and trait to include lazy logging 
> and refactor code to use the new LogHelper
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-193
>                 URL: https://issues.apache.org/jira/browse/KAFKA-193
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Joe Stein
>         Attachments: kafka-193.patch
>
>
> 1) New tait to include logging and helper methods so if 
> (log.isDebugEnabled()) is not required because it is in the helper and log 
> paramaters are passed by name so not executed to tidy up the code
> 2) refactor all occurrence of logging to use the log helper
> 3/4 (possibly to be handled in to tickets) the "lint" affect from this for 
> changes patched but not on trunk and new patches moving forward until this is 
> baked in

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to