[ 
https://issues.apache.org/jira/browse/KAFKA-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162600#comment-13162600
 ] 

Neha Narkhede commented on KAFKA-197:
-------------------------------------

Would it be reasonable to have KafkaServerStartable register a callback with 
KafkaServer, and have the shutdown API of KafkaServer invoke that callback ? 
That way, we can ensure that KafkaServerStartable can cleanly shutdown the 
embedded consumer when the server is shutdown for some reason.
                
> Embedded consumer doesn't shut down if the server can't start
> -------------------------------------------------------------
>
>                 Key: KAFKA-197
>                 URL: https://issues.apache.org/jira/browse/KAFKA-197
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.7
>            Reporter: Jun Rao
>             Fix For: 0.7.1
>
>         Attachments: KAFKA-197.patch
>
>
> If a broker embeds a consumer and the broker itself doesn't start (e.g., 
> conflicting broker id in ZK), the embedded consumer is still running. In this 
> case, we should probably shut down the embedded consumer too.
> To do this, we need to either throw an exception or return an error in 
> KafkaServer.startup and act accordingly in KafkaServerStartable.startup.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to