[ 
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228111#comment-13228111
 ] 

Prashanth Menon commented on KAFKA-49:
--------------------------------------

I've attached an updated patch.  

1. ProduceRequest always receives a ProducerResponse.  If acks=0, offsets in 
the response are treated as if acks=1, meaning only the leader has acked.
2. SyncProducer blocks waiting for a response from a ProducerRequest.
3. I've commented out ProducerTest.testZKSendWithDeadBroker since it relies on 
SyncProducer logic that will need to change.  It also will need to be rewritten 
with the changes coming in as part of KAFKA-45 leader election logic.

Let me know if I've missed anything!

                
> Add acknowledgement to the produce request.
> -------------------------------------------
>
>                 Key: KAFKA-49
>                 URL: https://issues.apache.org/jira/browse/KAFKA-49
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Prashanth Menon
>             Fix For: 0.8
>
>         Attachments: KAFKA-49-v1.patch, KAFKA-49-v2.patch
>
>
> Currently, the produce request doesn't get acknowledged. We need to have a 
> broker send a response to the producer and have the producer wait for the 
> response before sending the next request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to