[ 
https://issues.apache.org/jira/browse/KAFKA-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neha Narkhede updated KAFKA-307:
--------------------------------

    Attachment: kafka-307-v2.patch

Thanks for the review !

1. I like your suggestion. I wasn't quite satisfied with the way replicas were 
being managed. Incorporated the suggested changes. Looks much better now.

2. Didn't mean to check it in. But yes, I think zookeeper should be on ERROR 
and so should Kafka.
                
> Refactor server code to remove interdependencies between LogManager and 
> KafkaZooKeeper
> --------------------------------------------------------------------------------------
>
>                 Key: KAFKA-307
>                 URL: https://issues.apache.org/jira/browse/KAFKA-307
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.7, 0.8
>            Reporter: Neha Narkhede
>         Attachments: kafka-307-draft.patch, kafka-307-v2.patch
>
>
> Currently, LogManager wraps KafkaZooKeeper which is meant for all zookeeper 
> interaction of a Kafka server. With replication, KafkaZookeeper will handle 
> leader election, various state change listeners and then start replicas. Due 
> to interdependency between LogManager and KafkaZookeeper, starting replicas 
> is not possible until LogManager starts up completely. Due to this, we have 
> to separate the broker startup procedures required for replication to get 
> around this problem.
> It will be good to refactor and clean up the server code, before diving 
> deeper into replication.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to