Remove one-off Send objects --------------------------- Key: KAFKA-322 URL: https://issues.apache.org/jira/browse/KAFKA-322 Project: Kafka Issue Type: Improvement Components: core Affects Versions: 0.8 Reporter: Jay Kreps Assignee: Jay Kreps Priority: Minor Fix For: 0.8
We seem to be accumulating a bunch of unnecessary classes that implement Send. I am not sure why people are doing this. Example: ProducerResponseSend.scala It is not at all clear why we would add a custom send object for each request/response type. They all do the same thing. The only reason for having the concept of a Send object was to allow two implementations: ByteBufferSend and MessageSetSend, the later let's us abstract over the difference between a normal write and a sendfile() call. I think we can refactory ByteBufferSend to take one or more ByteBuffers instead of just one and delete all of these one-offs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira