[
https://issues.apache.org/jira/browse/KAFKA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252582#comment-13252582
]
Jun Rao commented on KAFKA-301:
-------------------------------
Thanks for the patch. Some comments:
1. some new files without Apache header.
2. ZKQueue: Reading items one at a time out of the queue seems expensive since
we have to read all children, sort them and get the head. The drainAll and
readAll api are much more efficient. Do we really need apis like poll and peek
that deal with one item at a time?
3. KafkaZooKeeper:
3.1 Can StateChangeRequestHandler be created inside StateChangeListener?
3.2 StateChangeListener.ensureEpochValidity(). Not all state changes are
initiated by a leader. For example, create topic ddl directly publishes state
change requests,
4. LeaderElectionTest: unused imports
5. No need to change VerifyConsumerRebalance.
6. Yes, it would be better if we use json representing the value of each state
change.
> Implement the broker startup procedure
> --------------------------------------
>
> Key: KAFKA-301
> URL: https://issues.apache.org/jira/browse/KAFKA-301
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Neha Narkhede
> Assignee: Neha Narkhede
> Labels: replication
> Attachments: kafka-301-draft.patch, kafka-301-v1.patch,
> kafka-301-v2.patch
>
>
> This JIRA will involve implementing the list of actions to be taken on broker
> startup, as listed by the brokerStartup() and startReplica() algorithm in the
> Kafka replication design doc. Since the stateChangeListener is part of
> KAFKA-44, this JIRA can leave it as a stub.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
