[
https://issues.apache.org/jira/browse/KAFKA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294581#comment-13294581
]
Jun Rao commented on KAFKA-329:
-------------------------------
Prashanth,
Thanks for patch v1. Some comments:
31. AdminUtils: remove used imports
32. CreateTopicCommand.createTopic(): add space after if when assigning to
partitionReplicaAssignment
33. TopicChangeListener.handleChildChange(): add a TODO comment for handling
topic deletion.
34. ZookeeperConsumerConnectorTest.testCompressionSetConsumption() seems to
always fail on sending messages now. Not clear to me why though.
> Remove the watches/broker for new topics and partitions and change create
> topic admin API to send start replica state change to all brokers
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-329
> URL: https://issues.apache.org/jira/browse/KAFKA-329
> Project: Kafka
> Issue Type: Sub-task
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Prashanth Menon
> Labels: replication
> Attachments: KAFKA-329-DRAFT-v2.patch, KAFKA-329-DRAFT.patch,
> KAFKA-329-v1.patch
>
>
> Currently in 0.8, all brokers register a watch on /brokers/topics and
> /brokers/topics/[topic] for all topics in a Kafka cluster. The watches are
> required to discover new topics.
> There is another way this can be achieved, as proposed here -
> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+replication+detailed+design+V2#KafkareplicationdetaileddesignV2-Createtopic
> Basically, the create-topic admin command sends start-replica state change
> request to all brokers in the assigned replicas list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
