[ 
https://issues.apache.org/jira/browse/KAFKA-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294758#comment-13294758
 ] 

Jun Rao commented on KAFKA-335:
-------------------------------

A few more comments for v5 patch.

41. KafkaController: There are a couple of corner cases.
41.1 registerSessionExpirationListener() need to be called even if the 
controller is not active.
41.2 if a broker can't become the controller, it needs to call 
registerControllerExistListener() to register the existence watcher.

42. ControllerChannelManager: startup() should use broker, not allBrokers. 
Also, allBrokers shouldn't be val.
                
> Implement an embedded controller
> --------------------------------
>
>                 Key: KAFKA-335
>                 URL: https://issues.apache.org/jira/browse/KAFKA-335
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Yang Ye
>             Fix For: 0.8
>
>         Attachments: kafka_controller_v1.patch, kafka_controller_v2.patch, 
> kafka_controller_v3.patch, kafka_controller_v4.patch, 
> kafka_controller_v4.patch, kafka_controller_v5.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> This ticket will implement a controller as described in 
> https://cwiki.apache.org/confluence/display/KAFKA/kafka+Detailed+Replication+Design+V3
> This includes creating the controller path, setting up necessary watchers 
> (e.g, Broker path and TopicPath), and failover the controller.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to