[
https://issues.apache.org/jira/browse/KAFKA-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403221#comment-13403221
]
Jun Rao commented on KAFKA-353:
-------------------------------
Thanks for patch v2. A couple of more comments:
21. DelayedProduce.isSatisfied(): The following check seems to be wrong. If
produce.requiredAcks < 0, numAcks is always going to be >=
produce.requiredAcks.
if (numAcks >= produce.requiredAcks ||
(numAcks >= isr.size && produce.requiredAcks < 0)) {
22. AsyncProducerTest seems to keep failing for me.
> tie producer-side ack with high watermark and progress of replicas
> ------------------------------------------------------------------
>
> Key: KAFKA-353
> URL: https://issues.apache.org/jira/browse/KAFKA-353
> Project: Kafka
> Issue Type: Sub-task
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Joel Koshy
> Attachments: kafka-353_v1.patch, kafka-353_v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
