[
https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416459#comment-13416459
]
Joel Koshy commented on KAFKA-404:
----------------------------------
Jonathan, thanks for taking this up. Couple of minor comments:
1 - May want to close the zkclient after creating the namespace.
2 - Can you use ZkUtils.makeSurePersistentPathExists?
3 - Use vals instead of the vars
4 - Can you also provide a patch for 0.8? Trunk and 0.8 are different enough
that we need to do double-commits going forward (i.e., until 0.8 is code
complete).
> When using chroot path, create chroot on startup if it doesn't exist
> --------------------------------------------------------------------
>
> Key: KAFKA-404
> URL: https://issues.apache.org/jira/browse/KAFKA-404
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.7.1
> Environment: CentOS 5.5, Linux 2.6.18-194.32.1.el5 x86_64 GNU/Linux
> Reporter: Jonathan Creasy
> Labels: newbie, patch
> Fix For: 0.8
>
> Attachments: KAFKA-404.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
