[ https://issues.apache.org/jira/browse/KAFKA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420740#comment-13420740 ]
Jay Kreps commented on KAFKA-405: --------------------------------- Also, ReplicaManager: This class has a very odd public interface. Instead of managing replicas it has a bunch of passive calls--addLocalReplica(), addRemoteReplica(), etc. Who calls these? KafkaServer seems to have its own wrapper for these. Then it passes these methods on as arguments to KafkaZookeeper. Does this make sense? I think it would be good if ReplicaManager handled replica management, even if that means it depends on zookeeper. > Improve the high water mark maintenance to store high watermarks for all > partitions in a single file on disk > ------------------------------------------------------------------------------------------------------------ > > Key: KAFKA-405 > URL: https://issues.apache.org/jira/browse/KAFKA-405 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.8 > Reporter: Neha Narkhede > Assignee: Neha Narkhede > Attachments: kafka-405-v1.patch, kafka-405-v2.patch > > > KAFKA-46 introduced per partition leader high watermarks. But it stores those > in one file per partition. A more performant solution would be to store all > high watermarks in a single file on disk -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira