[ https://issues.apache.org/jira/browse/KAFKA-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423248#comment-13423248 ]
Jun Rao commented on KAFKA-420: ------------------------------- First of all, we need to think through what message commits mean when there is only 1 replica in ISR. Does it mean message is in memory in the only replica or do we have to wait for the message to be flushed to disk. It seems to me that the latter is probably more meaningful and is compatible with what we have in 0.7. If the latter is what we want to implement, we will need to add a call to ReplicaManager.maybeIncrementLeaderHW from the log flushing logic. > maintain HW correctly with only 1 replica in ISR > ------------------------------------------------ > > Key: KAFKA-420 > URL: https://issues.apache.org/jira/browse/KAFKA-420 > Project: Kafka > Issue Type: Bug > Components: core > Affects Versions: 0.8 > Reporter: Jun Rao > Original Estimate: 72h > Remaining Estimate: 72h > > Currently, the HW maintenance logic is only triggered when handling fetch > requests from the follower. As a result, if the ISR has only 1 replica, the > HW won't be incremented since there is no request from the follower to > trigger the maintenance logic. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira