[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434184#comment-13434184 ]
Jun Rao commented on KAFKA-376: ------------------------------- Thanks for patch v1. It looks good overall. Some comments: 20. KafkaApis.availableFetchBytes: getting the leo of a replica can be done as leader.logEndOffset. 21. Could you rebase and make sure that single_host_multi_brokers under system_test passes? > expose different data to fetch requests from the follower replicas and > consumer clients > --------------------------------------------------------------------------------------- > > Key: KAFKA-376 > URL: https://issues.apache.org/jira/browse/KAFKA-376 > Project: Kafka > Issue Type: Bug > Components: core > Affects Versions: 0.8 > Reporter: Jun Rao > Attachments: KAFKA-376-DRAFT.patch, KAFKA-376-v1.patch > > Original Estimate: 168h > Remaining Estimate: 168h > > Currently, the broker always uses highwatermark to calculate the available > bytes to a fetch request, no matter where the request is from. Instead, we > should use highwatermark for requests coming from real consumer clients and > use logendoffset for requests coming from follower replicas. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira