[
https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437240#comment-13437240
]
Jun Rao commented on KAFKA-458:
-------------------------------
Thanks for patch v1. You only fixed the ByteBufferMessageSet in javaapi. There
is another ByteBufferMessageSet in kafka.messsage that needs to be fixed. Also,
in ByteBufferMessageSet, we should get rid of those get* methods and use the
val directly.
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-458-v1.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep
> errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
