[ 
https://issues.apache.org/jira/browse/KAFKA-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438000#comment-13438000
 ] 

Neha Narkhede commented on KAFKA-139:
-------------------------------------

3. In the earlier SBT version, if you run ./sbt package over and over, it 
re-created the jars for all subprojects each time. Now, I'm not so sure it does 
that ?
4. Like I said, all our scripts (*.sh) need to add the dependencies to the Java 
CLASSPATH. Right now, they point to the lib_managed directory and hence the 
system tests fail. 
5. You might want to run system tests before submitting the patch -
./system_test/*/bin/run-test.sh
6. Why does the patch change DefaultEventHandler to use a SortedMap ?

Would you be up for incorporating the changes suggested in review comments 1-6 
above and submitting a patch ? Rest of the patch looks good.

                
> cross-compile multiple Scala versions
> -------------------------------------
>
>                 Key: KAFKA-139
>                 URL: https://issues.apache.org/jira/browse/KAFKA-139
>             Project: Kafka
>          Issue Type: Improvement
>          Components: packaging
>    Affects Versions: 0.8
>            Reporter: Chris Burroughs
>              Labels: build
>             Fix For: 0.8
>
>         Attachments: kafka-sbt0-11-3-0.8.patch, kafka-sbt0-11-3-0.8-v2.patch, 
> kafka-sbt0-11-3-0.8-v3.patch, kafka-sbt0-11-3-0.8-v4.patch, 
> kafka-sbt0-11-3.patch
>
>
> Since scala does not maintain binary compatibly between versions, 
> organizations tend to have to move all of there code at the same time.  It 
> would thus be very helpful if we could cross build multiple scala versions.
> http://code.google.com/p/simple-build-tool/wiki/CrossBuild
> Unclear if this would require KAFKA-134 or just work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to