[ 
https://issues.apache.org/jira/browse/KAFKA-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Ghike updated KAFKA-475:
--------------------------------

    Attachment: kafka-475-v2.patch

Patch attached:
1. Time based log segment rollout added.

2. Moved the position of maybeRoll(segment) call in the Log to make sure that a 
new message does not get appended to a segment that has expired in time. 
   i. Accordingly modified the 
testCleanupSegmentsToMaintainSizeWithSizeBasedLogRoll

3. I have currently set the range of logRetentionHours and logRollHours to (1, 
24 * 7). An upper cap on the value of hours is necessary because a very high 
value of hours can overflow and become negative when converted to milliseconds. 

4. Unit tests added in LogTest 
    i.testTimeBasedLogRoll 
    ii. testSizeBasedLogRoll

5. Unit tests added in LogManagerTest (sorry couldn't come up with more concise 
names :\ )
    i. testCleanupSegmentsToMaintainSizeWithTimeBasedLogRoll
    ii. testCleanupExpiredSegmentsWithTimeBasedLogRoll
                
> Time based log segment rollout
> ------------------------------
>
>                 Key: KAFKA-475
>                 URL: https://issues.apache.org/jira/browse/KAFKA-475
>             Project: Kafka
>          Issue Type: New Feature
>    Affects Versions: 0.7.1
>            Reporter: Swapnil Ghike
>            Assignee: Swapnil Ghike
>              Labels: features
>             Fix For: 0.7.2
>
>         Attachments: kafka-475-v1.patch, kafka-475-v2.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Some applications might want their data to be deleted from the Kafka servers 
> earlier than the default retention time. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to