[ https://issues.apache.org/jira/browse/KAFKA-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440951#comment-13440951 ]
Jay Kreps commented on KAFKA-181: --------------------------------- +1 A couple nit picks: 1. VerifiableProperties is a "generic" utility class, so I don't think it should contain getCompressionCodec() which is pretty application specific. 2. It would be nice to put it in its own file kafka/utils/VerifiableProperties.scala > Log errors for unrecognized config options > ------------------------------------------ > > Key: KAFKA-181 > URL: https://issues.apache.org/jira/browse/KAFKA-181 > Project: Kafka > Issue Type: Improvement > Components: core > Affects Versions: 0.8 > Reporter: Joel Koshy > Assignee: Jun Rao > Labels: optimization > Fix For: 0.8 > > Attachments: kafka_181_v1.patch, kafka-181_v2.patch > > > Currently, unrecognized config options are silently ignored. Notably, if a > config has a typo or if a deprecated config is used, then there is no warning > issued and defaults are assumed. One can argue that the broker or a consumer > or a producer with an unrecognized config option should not even be allowed > to start up especially if defaults are silently assumed, but it would be good > to at least log an error. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira