[ 
https://issues.apache.org/jira/browse/KAFKA-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444575#comment-13444575
 ] 

Eli Reisman commented on KAFKA-468:
-----------------------------------

Hey David, if you're happy with your fix let me know and I can resolve mine (I 
was working on KAFKA-367.) The other end of mine is fact that in KAFKA-367 they 
want the UTF-8 to be configurable rather than set in stone, but I agree having 
some agreed-upon default is better than not setting one at all so your patch 
works for me if it works for you.

I am having trouble viewing your diff file, it comes up on Safari as a blank 
page URL -- could you check it?

Anyway let me know, and I can cancel KAFKA-367...or you're welcome to help 
complete it I think I was basically done and am just having a small problem 
with StringEncoder subclass. Will try to fix it tonight or tomorrow AM but not 
all that sure I will succeed as I am new to Scala.

Thanks again!

                
> String#getBytes is platform dependent
> -------------------------------------
>
>                 Key: KAFKA-468
>                 URL: https://issues.apache.org/jira/browse/KAFKA-468
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: David Arthur
>            Priority: Trivial
>             Fix For: 0.8
>
>         Attachments: KAFKA-468.diff
>
>
> Just noticed while looking at the source that some calls to 
> java.lang.String#getBytes do not include the encoding. They should probably 
> specify "UTF-8" for platform-independence.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to