[
https://issues.apache.org/jira/browse/KAFKA-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464453#comment-13464453
]
Jun Rao commented on KAFKA-501:
-------------------------------
Thanks for patch v1. Looks good overall. Some minor comments:
1. javaapi.OffsetRequest: No need to expose replicaId in the constructor since
all java clients are non-follower.
2. Log.getOffsetBefore, KafkaApis: So far, offsets are returned in ascending
order.
3. removed unused imports: LogManager, LogOffsetTest
4. UpdateOffsetsInZK: Not directly related to this jira, but this class should
probably be moved to tools package.
5. ZookeeperConsumerConnector: Do we need to import scala.Some?
Also, could you rebase?
> getOfffset Api needs to return different latest offset to regular and
> follower consumers
> ----------------------------------------------------------------------------------------
>
> Key: KAFKA-501
> URL: https://issues.apache.org/jira/browse/KAFKA-501
> Project: Kafka
> Issue Type: Bug
> Reporter: Jun Rao
> Assignee: Joel Koshy
> Priority: Blocker
> Labels: bugs
> Fix For: 0.8
>
> Attachments: KAFKA-501-v1.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> For follower consumers, getOffset should return logEndOffset as the latest
> offset. For regular consumers, getOffset should return highWatermark as the
> latest offset.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
