confirmed, will open JIRA, commit file with the license header and role RC5
I will also add to my notes to make sure to run and review rat before packaging a release I am also going to add the apache license to the sbt script it seems appropriate if we are going through and updating this same rat failure here is rest of rat results, i think just these 2 scripts need the header license and we are good. if not let me know ***************************************************** Files with Apache License headers will be marked AL Binary files (which do not require AL headers) will be marked B Compressed archives will be marked A Notices, licenses etc will be marked N !????? ./.gitignore !????? ./.rat-excludes N ./DISCLAIMER N ./LICENSE N ./NOTICE !????? ./README.md !????? ./sbt AL ./bin/kafka-console-consumer-log4j.properties AL ./bin/kafka-console-consumer.sh AL ./bin/kafka-console-producer.sh AL ./bin/kafka-consumer-perf-test.sh AL ./bin/kafka-consumer-shell.sh AL ./bin/kafka-producer-perf-test.sh AL ./bin/kafka-producer-shell.sh AL ./bin/kafka-replay-log-producer.sh AL ./bin/kafka-run-class.sh AL ./bin/kafka-server-start.sh AL ./bin/kafka-server-stop.sh AL ./bin/kafka-simple-consumer-perf-test.sh AL ./bin/kafka-simple-consumer-shell.sh AL ./bin/run-rat.sh AL ./bin/zookeeper-server-start.sh AL ./bin/zookeeper-server-stop.sh AL ./bin/zookeeper-shell.sh AL ./config/consumer.properties AL ./config/log4j.properties AL ./config/producer.properties AL ./config/server.properties AL ./config/zookeeper.properties N ./contrib/hadoop-consumer/LICENSE N ./contrib/hadoop-consumer/README AL ./contrib/hadoop-consumer/copy-jars.sh AL ./contrib/hadoop-consumer/hadoop-setup.sh AL ./contrib/hadoop-consumer/run-class.sh A ./contrib/hadoop-consumer/lib/piggybank.jar AL ./contrib/hadoop-consumer/src/main/java/kafka/etl/KafkaETLContext.java AL ./contrib/hadoop-consumer/src/main/java/kafka/etl/KafkaETLInputFormat.java AL ./contrib/hadoop-consumer/src/main/java/kafka/etl/KafkaETLJob.java AL ./contrib/hadoop-consumer/src/main/java/kafka/etl/KafkaETLKey.java AL ./contrib/hadoop-consumer/src/main/java/kafka/etl/KafkaETLRecordReader.java AL ./contrib/hadoop-consumer/src/main/java/kafka/etl/KafkaETLRequest.java AL ./contrib/hadoop-consumer/src/main/java/kafka/etl/KafkaETLUtils.java AL ./contrib/hadoop-consumer/src/main/java/kafka/etl/Props.java AL ./contrib/hadoop-consumer/src/main/java/kafka/etl/UndefinedPropertyException.java AL ./contrib/hadoop-consumer/src/main/java/kafka/etl/impl/DataGenerator.java AL ./contrib/hadoop-consumer/src/main/java/kafka/etl/impl/SimpleKafkaETLJob.java AL ./contrib/hadoop-consumer/src/main/java/kafka/etl/impl/SimpleKafkaETLMapper.java AL ./contrib/hadoop-consumer/test/test.properties N ./contrib/hadoop-producer/LICENSE !????? ./contrib/hadoop-producer/README.md A ./contrib/hadoop-producer/lib/piggybank.jar AL ./contrib/hadoop-producer/src/main/java/kafka/bridge/examples/TextPublisher.java AL ./contrib/hadoop-producer/src/main/java/kafka/bridge/hadoop/KafkaOutputFormat.java AL ./contrib/hadoop-producer/src/main/java/kafka/bridge/hadoop/KafkaRecordWriter.java AL ./contrib/hadoop-producer/src/main/java/kafka/bridge/pig/AvroKafkaStorage.java AL ./core/src/main/scala/kafka/Kafka.scala AL ./core/src/main/scala/kafka/api/FetchRequest.scala AL ./core/src/main/scala/kafka/api/MultiFetchRequest.scala AL ./core/src/main/scala/kafka/api/MultiFetchResponse.scala AL ./core/src/main/scala/kafka/api/MultiProducerRequest.scala AL ./core/src/main/scala/kafka/api/OffsetRequest.scala AL ./core/src/main/scala/kafka/api/ProducerRequest.scala AL ./core/src/main/scala/kafka/api/RequestKeys.scala AL ./core/src/main/scala/kafka/cluster/Broker.scala AL ./core/src/main/scala/kafka/cluster/Cluster.scala AL ./core/src/main/scala/kafka/cluster/Partition.scala AL ./core/src/main/scala/kafka/common/ConsumerReblanceFailedException.scala AL ./core/src/main/scala/kafka/common/ErrorMapping.scala AL ./core/src/main/scala/kafka/common/InvalidConfigException.scala AL ./core/src/main/scala/kafka/common/InvalidMessageSizeException.scala AL ./core/src/main/scala/kafka/common/InvalidPartitionException.scala AL ./core/src/main/scala/kafka/common/NoBrokersForPartitionException.scala AL ./core/src/main/scala/kafka/common/OffsetOutOfRangeException.scala AL ./core/src/main/scala/kafka/common/UnavailableProducerException.scala AL ./core/src/main/scala/kafka/common/UnknownCodecException.scala AL ./core/src/main/scala/kafka/common/UnknownException.scala AL ./core/src/main/scala/kafka/common/UnknownMagicByteException.scala AL ./core/src/main/scala/kafka/consumer/ConsoleConsumer.scala AL ./core/src/main/scala/kafka/consumer/ConsumerConfig.scala AL ./core/src/main/scala/kafka/consumer/ConsumerConnector.scala AL ./core/src/main/scala/kafka/consumer/ConsumerIterator.scala AL ./core/src/main/scala/kafka/consumer/ConsumerTopicStat.scala AL ./core/src/main/scala/kafka/consumer/FetchedDataChunk.scala AL ./core/src/main/scala/kafka/consumer/Fetcher.scala AL ./core/src/main/scala/kafka/consumer/FetcherRunnable.scala AL ./core/src/main/scala/kafka/consumer/KafkaStream.scala AL ./core/src/main/scala/kafka/consumer/PartitionTopicInfo.scala AL ./core/src/main/scala/kafka/consumer/SimpleConsumer.scala AL ./core/src/main/scala/kafka/consumer/TopicCount.scala AL ./core/src/main/scala/kafka/consumer/TopicEventHandler.scala AL ./core/src/main/scala/kafka/consumer/TopicFilter.scala AL ./core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala AL ./core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala !????? ./core/src/main/scala/kafka/consumer/package.html AL ./core/src/main/scala/kafka/consumer/storage/MemoryOffsetStorage.scala AL ./core/src/main/scala/kafka/consumer/storage/OffsetStorage.scala AL ./core/src/main/scala/kafka/consumer/storage/OracleOffsetStorage.scala AL ./core/src/main/scala/kafka/javaapi/Implicits.scala AL ./core/src/main/scala/kafka/javaapi/MultiFetchResponse.scala AL ./core/src/main/scala/kafka/javaapi/ProducerRequest.scala AL ./core/src/main/scala/kafka/javaapi/consumer/ConsumerConnector.java AL ./core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala AL ./core/src/main/scala/kafka/javaapi/consumer/ZookeeperConsumerConnector.scala AL ./core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala AL ./core/src/main/scala/kafka/javaapi/message/MessageSet.scala AL ./core/src/main/scala/kafka/javaapi/producer/Producer.scala AL ./core/src/main/scala/kafka/javaapi/producer/ProducerData.scala AL ./core/src/main/scala/kafka/javaapi/producer/SyncProducer.scala AL ./core/src/main/scala/kafka/javaapi/producer/async/CallbackHandler.java AL ./core/src/main/scala/kafka/javaapi/producer/async/EventHandler.java AL ./core/src/main/scala/kafka/log/Log.scala AL ./core/src/main/scala/kafka/log/LogManager.scala AL ./core/src/main/scala/kafka/log/LogStats.scala AL ./core/src/main/scala/kafka/log/SegmentList.scala !????? ./core/src/main/scala/kafka/log/package.html AL ./core/src/main/scala/kafka/message/ByteBufferBackedInputStream.scala AL ./core/src/main/scala/kafka/message/ByteBufferMessageSet.scala AL ./core/src/main/scala/kafka/message/CompressionCodec.scala AL ./core/src/main/scala/kafka/message/CompressionUtils.scala AL ./core/src/main/scala/kafka/message/FileMessageSet.scala AL ./core/src/main/scala/kafka/message/InvalidMessageException.scala AL ./core/src/main/scala/kafka/message/Message.scala AL ./core/src/main/scala/kafka/message/MessageAndMetadata.scala AL ./core/src/main/scala/kafka/message/MessageAndOffset.scala AL ./core/src/main/scala/kafka/message/MessageLengthException.scala AL ./core/src/main/scala/kafka/message/MessageSet.scala !????? ./core/src/main/scala/kafka/message/package.html AL ./core/src/main/scala/kafka/network/BoundedByteBufferReceive.scala AL ./core/src/main/scala/kafka/network/BoundedByteBufferSend.scala AL ./core/src/main/scala/kafka/network/ByteBufferSend.scala AL ./core/src/main/scala/kafka/network/ConnectionConfig.scala AL ./core/src/main/scala/kafka/network/Handler.scala AL ./core/src/main/scala/kafka/network/InvalidRequestException.scala AL ./core/src/main/scala/kafka/network/Request.scala AL ./core/src/main/scala/kafka/network/SocketServer.scala AL ./core/src/main/scala/kafka/network/SocketServerStats.scala AL ./core/src/main/scala/kafka/network/Transmission.scala !????? ./core/src/main/scala/kafka/network/package.html AL ./core/src/main/scala/kafka/producer/BrokerPartitionInfo.scala AL ./core/src/main/scala/kafka/producer/ConfigBrokerPartitionInfo.scala AL ./core/src/main/scala/kafka/producer/ConsoleProducer.scala AL ./core/src/main/scala/kafka/producer/DefaultPartitioner.scala AL ./core/src/main/scala/kafka/producer/KafkaLog4jAppender.scala AL ./core/src/main/scala/kafka/producer/Partitioner.scala AL ./core/src/main/scala/kafka/producer/Producer.scala AL ./core/src/main/scala/kafka/producer/ProducerConfig.scala AL ./core/src/main/scala/kafka/producer/ProducerData.scala AL ./core/src/main/scala/kafka/producer/ProducerPool.scala AL ./core/src/main/scala/kafka/producer/SyncProducer.scala AL ./core/src/main/scala/kafka/producer/SyncProducerConfig.scala AL ./core/src/main/scala/kafka/producer/ZKBrokerPartitionInfo.scala AL ./core/src/main/scala/kafka/producer/async/AsyncProducer.scala AL ./core/src/main/scala/kafka/producer/async/AsyncProducerConfig.scala AL ./core/src/main/scala/kafka/producer/async/AsyncProducerInterruptedException.scala AL ./core/src/main/scala/kafka/producer/async/AsyncProducerStats.scala AL ./core/src/main/scala/kafka/producer/async/AsyncProducerStatsMBean.scala AL ./core/src/main/scala/kafka/producer/async/CallbackHandler.scala AL ./core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala AL ./core/src/main/scala/kafka/producer/async/EventHandler.scala AL ./core/src/main/scala/kafka/producer/async/IllegalQueueStateException.scala AL ./core/src/main/scala/kafka/producer/async/MissingConfigException.scala AL ./core/src/main/scala/kafka/producer/async/ProducerSendThread.scala AL ./core/src/main/scala/kafka/producer/async/QueueClosedException.scala AL ./core/src/main/scala/kafka/producer/async/QueueFullException.scala AL ./core/src/main/scala/kafka/serializer/Decoder.scala AL ./core/src/main/scala/kafka/serializer/Encoder.scala AL ./core/src/main/scala/kafka/server/KafkaConfig.scala AL ./core/src/main/scala/kafka/server/KafkaRequestHandlers.scala AL ./core/src/main/scala/kafka/server/KafkaServer.scala AL ./core/src/main/scala/kafka/server/KafkaServerStartable.scala AL ./core/src/main/scala/kafka/server/KafkaZooKeeper.scala AL ./core/src/main/scala/kafka/server/MessageSetSend.scala AL ./core/src/main/scala/kafka/server/MultiMessageSetSend.scala !????? ./core/src/main/scala/kafka/server/package.html AL ./core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala AL ./core/src/main/scala/kafka/tools/ConsumerShell.scala AL ./core/src/main/scala/kafka/tools/DumpLogSegments.scala AL ./core/src/main/scala/kafka/tools/ExportZkOffsets.scala AL ./core/src/main/scala/kafka/tools/GetOffsetShell.scala AL ./core/src/main/scala/kafka/tools/ImportZkOffsets.scala AL ./core/src/main/scala/kafka/tools/JmxTool.scala AL ./core/src/main/scala/kafka/tools/MirrorMaker.scala AL ./core/src/main/scala/kafka/tools/ProducerShell.scala AL ./core/src/main/scala/kafka/tools/ReplayLogProducer.scala AL ./core/src/main/scala/kafka/tools/SimpleConsumerShell.scala AL ./core/src/main/scala/kafka/tools/VerifyConsumerRebalance.scala AL ./core/src/main/scala/kafka/utils/Annotations.scala AL ./core/src/main/scala/kafka/utils/DelayedItem.scala AL ./core/src/main/scala/kafka/utils/IteratorTemplate.scala AL ./core/src/main/scala/kafka/utils/KafkaScheduler.scala AL ./core/src/main/scala/kafka/utils/Log4jController.scala AL ./core/src/main/scala/kafka/utils/Logging.scala AL ./core/src/main/scala/kafka/utils/MockTime.scala AL ./core/src/main/scala/kafka/utils/Mx4jLoader.scala AL ./core/src/main/scala/kafka/utils/Pool.scala AL ./core/src/main/scala/kafka/utils/Range.scala AL ./core/src/main/scala/kafka/utils/Throttler.scala AL ./core/src/main/scala/kafka/utils/Time.scala AL ./core/src/main/scala/kafka/utils/TopicNameValidator.scala AL ./core/src/main/scala/kafka/utils/UpdateOffsetsInZK.scala AL ./core/src/main/scala/kafka/utils/Utils.scala AL ./core/src/main/scala/kafka/utils/ZkUtils.scala !????? ./core/src/main/scala/kafka/utils/package.html AL ./core/src/test/resources/log4j.properties !????? ./core/src/test/resources/test-kafka-logs/MagicByte0-0/00000000000000000000.kafka AL ./core/src/test/scala/other/kafka.log4j.properties AL ./core/src/test/scala/other/kafka/DeleteZKPath.scala AL ./core/src/test/scala/other/kafka/TestKafkaAppender.scala AL ./core/src/test/scala/other/kafka/TestLinearWriteSpeed.scala AL ./core/src/test/scala/other/kafka/TestLogPerformance.scala AL ./core/src/test/scala/other/kafka/TestTruncate.scala AL ./core/src/test/scala/other/kafka/TestZKConsumerOffsets.scala AL ./core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala AL ./core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala AL ./core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala AL ./core/src/test/scala/unit/kafka/integration/BackwardsCompatibilityTest.scala AL ./core/src/test/scala/unit/kafka/integration/FetcherTest.scala AL ./core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala AL ./core/src/test/scala/unit/kafka/integration/LazyInitProducerTest.scala AL ./core/src/test/scala/unit/kafka/integration/LogCorruptionTest.scala AL ./core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala AL ./core/src/test/scala/unit/kafka/integration/ProducerConsumerTestHarness.scala AL ./core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala AL ./core/src/test/scala/unit/kafka/javaapi/integration/PrimitiveApiTest.scala AL ./core/src/test/scala/unit/kafka/javaapi/integration/ProducerConsumerTestHarness.scala AL ./core/src/test/scala/unit/kafka/javaapi/message/BaseMessageSetTestCases.scala AL ./core/src/test/scala/unit/kafka/javaapi/message/ByteBufferMessageSetTest.scala AL ./core/src/test/scala/unit/kafka/javaapi/producer/ProducerTest.scala AL ./core/src/test/scala/unit/kafka/javaapi/producer/SyncProducerTest.scala AL ./core/src/test/scala/unit/kafka/log/LogManagerTest.scala AL ./core/src/test/scala/unit/kafka/log/LogOffsetTest.scala AL ./core/src/test/scala/unit/kafka/log/LogTest.scala AL ./core/src/test/scala/unit/kafka/log/SegmentListTest.scala AL ./core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala AL ./core/src/test/scala/unit/kafka/message/BaseMessageSetTestCases.scala AL ./core/src/test/scala/unit/kafka/message/ByteBufferMessageSetTest.scala AL ./core/src/test/scala/unit/kafka/message/CompressionUtilsTest.scala AL ./core/src/test/scala/unit/kafka/message/FileMessageSetTest.scala AL ./core/src/test/scala/unit/kafka/message/MessageTest.scala AL ./core/src/test/scala/unit/kafka/network/SocketServerTest.scala AL ./core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala AL ./core/src/test/scala/unit/kafka/producer/ProducerMethodsTest.scala AL ./core/src/test/scala/unit/kafka/producer/ProducerTest.scala AL ./core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala AL ./core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala AL ./core/src/test/scala/unit/kafka/utils/TestUtils.scala AL ./core/src/test/scala/unit/kafka/utils/UtilsTest.scala AL ./core/src/test/scala/unit/kafka/zk/EmbeddedZookeeper.scala AL ./core/src/test/scala/unit/kafka/zk/ZKEphemeralTest.scala AL ./core/src/test/scala/unit/kafka/zk/ZKLoadBalanceTest.scala AL ./core/src/test/scala/unit/kafka/zk/ZooKeeperTestHarness.scala N ./examples/README AL ./examples/bin/java-producer-consumer-demo.sh AL ./examples/bin/java-simple-consumer-demo.sh AL ./examples/src/main/java/kafka/examples/Consumer.java AL ./examples/src/main/java/kafka/examples/ExampleUtils.java AL ./examples/src/main/java/kafka/examples/KafkaConsumerProducerDemo.java AL ./examples/src/main/java/kafka/examples/KafkaProperties.java AL ./examples/src/main/java/kafka/examples/Producer.java AL ./examples/src/main/java/kafka/examples/SimpleConsumerDemo.java A ./lib/sbt-launch.jar AL ./perf/config/log4j.properties AL ./perf/src/main/scala/kafka/perf/ConsumerPerformance.scala AL ./perf/src/main/scala/kafka/perf/PerfConfig.scala AL ./perf/src/main/scala/kafka/perf/ProducerPerformance.scala AL ./perf/src/main/scala/kafka/perf/SimpleConsumerPerformance.scala AL ./project/build.properties AL ./project/build/KafkaProject.scala AL ./project/plugins/Plugins.scala N ./system_test/broker_failure/README AL ./system_test/broker_failure/bin/kafka-run-class.sh AL ./system_test/broker_failure/bin/run-test.sh AL ./system_test/broker_failure/config/log4j.properties AL ./system_test/broker_failure/config/mirror_producer.properties AL ./system_test/broker_failure/config/mirror_producer1.properties AL ./system_test/broker_failure/config/mirror_producer2.properties AL ./system_test/broker_failure/config/mirror_producer3.properties AL ./system_test/broker_failure/config/server_source1.properties AL ./system_test/broker_failure/config/server_source2.properties AL ./system_test/broker_failure/config/server_source3.properties AL ./system_test/broker_failure/config/server_source4.properties AL ./system_test/broker_failure/config/server_target1.properties AL ./system_test/broker_failure/config/server_target2.properties AL ./system_test/broker_failure/config/server_target3.properties AL ./system_test/broker_failure/config/whitelisttest.consumer.properties AL ./system_test/broker_failure/config/zookeeper_source.properties AL ./system_test/broker_failure/config/zookeeper_target.properties !????? ./system_test/common/util.sh N ./system_test/mirror_maker/README !????? ./system_test/mirror_maker/bin/expected.out AL ./system_test/mirror_maker/bin/run-test.sh AL ./system_test/mirror_maker/config/blacklisttest.consumer.properties AL ./system_test/mirror_maker/config/mirror_producer.properties AL ./system_test/mirror_maker/config/server_source_1_1.properties AL ./system_test/mirror_maker/config/server_source_1_2.properties AL ./system_test/mirror_maker/config/server_source_2_1.properties AL ./system_test/mirror_maker/config/server_source_2_2.properties AL ./system_test/mirror_maker/config/server_target_1_1.properties AL ./system_test/mirror_maker/config/server_target_1_2.properties AL ./system_test/mirror_maker/config/whitelisttest_1.consumer.properties AL ./system_test/mirror_maker/config/whitelisttest_2.consumer.properties AL ./system_test/mirror_maker/config/zookeeper_source_1.properties AL ./system_test/mirror_maker/config/zookeeper_source_2.properties AL ./system_test/mirror_maker/config/zookeeper_target.properties N ./system_test/producer_perf/README !????? ./system_test/producer_perf/bin/expected.out AL ./system_test/producer_perf/bin/run-compression-test.sh AL ./system_test/producer_perf/bin/run-test.sh AL ./system_test/producer_perf/config/server.properties AL ./system_test/producer_perf/config/zookeeper.properties On Fri, Sep 28, 2012 at 2:33 PM, Joel Koshy <jjkosh...@gmail.com> wrote: > Rat fails on the system_test/common/util.sh as it is missing the license. > > Joel > > On Friday, September 28, 2012, Jay Kreps wrote: > > > +1 > > > > -Jay > > > > On Fri, Sep 28, 2012 at 8:28 AM, Jun Rao <jun...@gmail.com<javascript:;>> > > wrote: > > > > > +1. Checked LICENSE and NOTICE. Quickstart commands work. > > > > > > Thanks, > > > > > > Jun > > > > > > On Wed, Sep 26, 2012 at 6:06 PM, Joe Stein <crypt...@gmail.com > <javascript:;>> > > wrote: > > > > > > > Hello, > > > > > > > > This is the fourth candidate for the third incubator release for > Apache > > > > Kafka, version 0.7.2-incubating > > > > > > > > This release fixes the following issues > > > > > > > > > > > > > > http://people.apache.org/~joestein/kafka-0.7.2-incubating-candidate-4/RELEASE-NOTES.html > > > > > > > > *** Please download, test and vote by Saturday September, 28th, 9pm > PDT > > > *** > > > > > > > > Release artifacts to be voted upon: > > > > > > https://people.apache.org/~joestein/kafka-0.7.2-incubating-candidate-4/ > > > > > > > > The tag (off the 0.7.2 branch) for release artifacts: > > > > > > > > > > > > > > https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.2-incubating-candidate-4 > > > > > > > > Kafka's KEYS file containing PGP keys we use to sign the release: > > > > https://svn.apache.org/repos/asf/incubator/kafka/KEYS > > > > > > > > /* > > > > Joe Stein > > > > http://www.linkedin.com/in/charmalloc > > > > Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop> > > > > */ > > > > > > > > > > -- /* Joe Stein http://www.linkedin.com/in/charmalloc Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop> */