[
https://issues.apache.org/jira/browse/KAFKA-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469530#comment-13469530
]
Jun Rao commented on KAFKA-456:
-------------------------------
Thanks for the patch. Committed to 0.8.
This performance issue seems to have been fixed in scala 2.9.1.
https://issues.scala-lang.org/browse/SI-4933
> ProducerSendThread calls ListBuffer.size a whole bunch. That is a O(n)
> operation
> --------------------------------------------------------------------------------
>
> Key: KAFKA-456
> URL: https://issues.apache.org/jira/browse/KAFKA-456
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Environment: NA
> Reporter: Matthew Rathbone
> Priority: Minor
> Labels: newbie
> Fix For: 0.8
>
> Attachments: KAFKA-456.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hi all,
> So there are various statements throughout the async code that call
> 'events.size', mostly for debugging purposes.
> Problem is that this call is O(n), so it could add up if the batch size is
> high. (it's a ListBuffer)
> I see this in at least ProducerSendThread (x4), likely more. Will factor this
> out myself soon when I start hacking on the project, just wanted to put this
> somewhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
