[ https://issues.apache.org/jira/browse/KAFKA-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang Ye updated KAFKA-510: -------------------------- Attachment: kafka_510_v4.diff I still use toString() instead of toZkString() in leaderAndISR, because I find we do have code recovering leaderAndISR from zookeeper, including the replication factor: ZkUtils.getLeaderForPartition() Although we can still get rid of it, which means a lot of code, not good encapsulation. I prefer not. The rest of comments for v3 are addressed. > broker needs to know the replication factor per partition > --------------------------------------------------------- > > Key: KAFKA-510 > URL: https://issues.apache.org/jira/browse/KAFKA-510 > Project: Kafka > Issue Type: Bug > Components: core > Reporter: Jun Rao > Assignee: Yang Ye > Priority: Blocker > Labels: bugs > Fix For: 0.8 > > Attachments: kafka_510_v1.diff, kafka_510_v2.diff, kafka_510_v3.diff, > kafka_510_v4.diff > > Original Estimate: 24h > Remaining Estimate: 24h > > A broker needs to know the replication factor to report under replicated > partitions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira