[
https://issues.apache.org/jira/browse/KAFKA-557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473822#comment-13473822
]
Neha Narkhede commented on KAFKA-557:
-------------------------------------
1.2 Understand, but that's what we've been following throughout the code. If
you want to propose a different line wrapping convention, let's discuss that to
keep things consistent.
1.3 Agree that all if/else with simple boolean statements shouldn't be replaced
by case-match. I was specifically referring to if-else statements that are
meant to evaluate to a certain value. In such scenarios, case-match guarantees
evaluation to a value unlike if-else, so it is safer. However, that is just my
preference, you can keep it if you disagree.
Latest patch looks good otherwise.
> Replica fetch thread doesn't need to recompute message id
> ---------------------------------------------------------
>
> Key: KAFKA-557
> URL: https://issues.apache.org/jira/browse/KAFKA-557
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Priority: Blocker
> Labels: bugs
> Attachments: KAFKA-557.patch, KAFKA-557.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> With kafka-506, the leader broker computes the logical id for each message
> produced. This could involve decompressing and recompressing messages, which
> are expensive. When data is replicated from the leader to the follower, we
> could avoid recomputing the logical message id since it's the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
