[
https://issues.apache.org/jira/browse/KAFKA-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475318#comment-13475318
]
Joel Koshy commented on KAFKA-43:
---------------------------------
Patch doesn't apply to 0.8 head so you will need to rebase. Here are some
additional comments:
PreferredReplicaLeaderElectionCommand:
- There's a Utils.checkRequiredArgs helper that you can use.
- Shutdown hook should close zkClient.
- updatePreferredReplicaElectionData is unused - or is this meant to support
concurrent invocations of the tool in the
future?
- Would be good to have a short --help string for all the admin tools.
- Spacing conventions: some places have no space between the last character and
opening brace, else should be on new
line, etc.
KafkaController:
- Instead of nulls in the controller context, can we switch to Set.empty? I can
try that in KAFKA-340 as well.
- Would be clearer to rename removePartitionsFromPreferredReplicaElection to
maybeRemove...
- Also, the name removePartitionsFromPreferredReplicationElection does not
document the side-effect of deleting the
PreferredReplicaLeaderElectionPath. The delete can be moved to a finally
block of handleDataChange. In fact,
it seems removePartitionsFromPreferredReplicaElection can also be moved (from
onPreferredReplicaElection) to the
finally block.
- Likewise, the initialize(ReassignedPartitions|PreferredElection)Context have
the additional side-effect of actually
triggering the operation so can we rename accordingly? e.g.,
triggerPreferredReplicaLeaderElection would be a
sufficient name since these two "contexts" really live in ControllerContext.
Revert test log4j.properties
TestUtils.readFileIntoString can be removed.
> Rebalance to preferred broke with intra-cluster replication support
> -------------------------------------------------------------------
>
> Key: KAFKA-43
> URL: https://issues.apache.org/jira/browse/KAFKA-43
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Jun Rao
> Assignee: Neha Narkhede
> Priority: Blocker
> Labels: features
> Fix For: 0.8
>
> Attachments: kafka-43-v1.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> We need to allow the leader to be moved to the preferred broker, for better
> load balancing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
