[
https://issues.apache.org/jira/browse/KAFKA-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475430#comment-13475430
]
Neha Narkhede commented on KAFKA-569:
-------------------------------------
Looks good, just one thing that I missed in the first review - I see you added
a counter to DefaultEventHandler for the round-robin load-balancing. For a long
running producer, the counter could overflow to a negative value. I think we
need to reset it to 0, no ?
+1 otherwise.
> Cleanup kafka.utils.Utils
> -------------------------
>
> Key: KAFKA-569
> URL: https://issues.apache.org/jira/browse/KAFKA-569
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Jay Kreps
> Assignee: Jay Kreps
> Attachments: KAFKA-569.patch, KAFKA-569-v2.patch
>
>
> kafka.utils.Utils is a real mess. It is full of odd little pieces of business
> logic dropped there. We should clean this up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
