[ https://issues.apache.org/jira/browse/KAFKA-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490305#comment-13490305 ]
Neha Narkhede commented on KAFKA-577: ------------------------------------- Sorry for coming to this a little late. Patch v5 looks good, just one suggestion - Looks like DumpLogSegments is the only tool that doesn't quite follow the convention for argument parsing. It will be good to standardize on jopt parser since it also helps with a description for each option, a help command and convenient required argument checks. Just my 2c. > extend DumpLogSegments to verify consistency btw data and index > --------------------------------------------------------------- > > Key: KAFKA-577 > URL: https://issues.apache.org/jira/browse/KAFKA-577 > Project: Kafka > Issue Type: Bug > Components: core > Affects Versions: 0.8 > Reporter: Jun Rao > Labels: newbie, tools > Fix For: 0.8 > > Attachments: kafka_577_v1.diff, kafka_577_v2.diff, kafka_577_v3.diff, > kafka_577_v4.diff, kafka_577_v5.diff > > Original Estimate: 24h > Remaining Estimate: 24h > > It would be good to extend DumpLogSegments to do the following verification: > 1. The offsets stored in the index match those in the log data. > 2. The offsets in the data log is consecutive. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira