On Thu, Feb 19, 2015 at 5:01 PM, Mads Kiilerich <[email protected]> wrote: > On 02/19/2015 01:36 PM, Thomas De Schampheleire wrote: >> >> For commit messages with the first line being very long, the 'latest >> changes' >> table on the repository overview page can 'bleed', so that the commit >> number >> overlaps with the commit status. >> >> Commit 15cb8156b10d732cf39b37a88c656894621c0f54 changed the initial >> truncate >> on 50 characters to a chop at the first newline characters. >> In this commit, re-add a truncation of the first line, at 120 characters. > > > Wouldn't it be better to do that truncation in css, setting some max width > of the column and hide overflow? > > The 120 seems a bit arbitrary and closely related to the actual styling of > the page (and screen size). > > > 2nd thought after having a closer look, and reproduced it by making the > browser window very narrow: > > The root cause of this seems to be that our templates / styling has an > annoying addiction to 'float'. > > The right fix would be to do something to this changeset-status-container. > Perhaps give it is own table column ... or at least set a min width on the > changeset column ... or give the pre with the hash a margin-right:25px . >
You're right, the 120 truncate is a bit of a hack. I just sent a v2 that uses dedicated columns, which works fine even on small windows. _______________________________________________ kallithea-general mailing list [email protected] http://lists.sfconservancy.org/mailman/listinfo/kallithea-general
