On Mon, Feb 23, 2015 at 4:21 PM, Mads Kiilerich <m...@kiilerich.com> wrote: [..] >>> >>> Yes. "Pages working in the context of a repo (and usually a >>> changeset/branch)" is so common and important that I think it makes sense >>> to >>> have extra support and convenience functions for that. >>> >>> It would perhaps be nice to have a separate template for such pages. >>> >>> https://bitbucket.org/conservancy/kallithea/pull-request/52/replaced-the-old-switch-to-dropdown-with >>> would also fit in nicely there. >> >> When you say 'would fit nicely there' you mean to extract the code >> added in that pullrequest would be moved away from base.html to this >> new template? >> And would you create a separate base_repo.html (or something) or >> rather inherit from base.html ? > > > Yes, something like that. That would however be scope creep. So let's just > take your initial fix and keep this in mind.
A basic version of the initial improvement was just sent. > >>> root.html has some special hacks for using c.repo_name when it is >>> defined. >>> For now I think it would be fine to handle branding and repo name the >>> same >>> way. >>> >>> (A related "feature request": People often have multiple tabs open and >>> they >>> only see 10 characters of the page title. They want to see the most >>> important info there so they can tell them apart. But for some users that >>> will be the hostname/branding, for others it will be the repo name, for >>> others it will be the branch name, for others it will be the pull request >>> number or name (when applicable). I don't see a good solution to that. >>> But >>> let's keep the branding at the end.) >>> >> And here your feature request is to keep the branding at the end? >> Or would the feature be the configuration of the page title based on >> some %foo modifiers? > > > I don't know a good solution but I kind of understand the problem. You can > perhaps help keeping it in mind and see if a solution / improvement pops up. I really think we should write such things down somewhere, instead of having it in your and my mind only. _______________________________________________ kallithea-general mailing list kallithea-general@sfconservancy.org http://lists.sfconservancy.org/mailman/listinfo/kallithea-general