On Sun, Apr 19, 2015 at 12:20 AM, Mads Kiilerich <[email protected]> wrote: > On 04/18/2015 04:11 PM, Thomas De Schampheleire wrote: >> >> # HG changeset patch >> # User Thomas De Schampheleire <[email protected]> >> # Date 1429265659 -7200 >> # Fri Apr 17 12:14:19 2015 +0200 >> # Node ID 6e760af6050e567239155a7a43b5ab02eddf877d >> # Parent 32de32f6946110ecd0b8d2c79f0270025f3afaca >> pullrequests: add support for custom pull request id prefix >> >> Currently, a pull request id is referenced as #5, and the '#' symbol is >> fixed. >> This commit adds a configuration parameter 'pull_request_prefix', >> defaulting >> to '#', that can be used to customize the prefix. >> >> For example, one could use 'PR-' to create references of the form 'PR-5'. > > > Yes, the # notation is weird. > > But we can't make everything configurable. I think it would be better to > just use 'PR-' everywhere.
My use case is this: we are planning to run different Kallithea instances, one in each of our (geographically separated) sites. The reviews (pull requests) are supposed to be traceable throughout history, so references to such reviews are to have unique IDs across these different Kallithea instances. Since they do not share the same database, there will be several pull requests #4. Same for PR-4. Therefore, we plan to use a pull request reference that contain a reference to the site, for example: PR-<site>-4. This patch is a solution that supports this idea in an upstreamable way, without too much complexity. Would you reconsider this patch after this background? Thanks, Thomas _______________________________________________ kallithea-general mailing list [email protected] http://lists.sfconservancy.org/mailman/listinfo/kallithea-general
