On 04/19/2015 01:11 PM, Jan Heylen wrote:
On Sun, Apr 19, 2015 at 6:37 PM, Mads Kiilerich <[email protected]> wrote:
My main unsolicited thought is that I would see this as something closely
related to having versioning of comments so they can be edited or deleted
while leaving history tracks. A draft comment would be something that
haven't been made active yet. I am not entirely sure what datamodel would
fit that need but it seems to me like we should implement edit+delete before
draft ... or at least design them together.
If you would like versioned comments, that would be a very different
story, that would/could mean that you put your comments in a version
control system, e.g. mercurial ;-p
Yes, that has come up in conversations too. Crazy because it is true! ;-)
There are valid use cases for being able to do code reviews or address
code reviews locally and offline.
That might not be feasible short term but I think it is closely related
to being able to carry comments forward to updated "pull requests" so it
can be verified that they really have been addressed.
/Mads
_______________________________________________
kallithea-general mailing list
[email protected]
http://lists.sfconservancy.org/mailman/listinfo/kallithea-general